Conversation
- Enable SSH agent service in CI workflow before Windows tests - Remove -Skip from SupportsShouldProcess test block (feature already implemented) - Update private IPs test to use AST-based detection (allows IPs in comments/strings) - Add Test-NoPrivateIPsInCode helper function to TestHelpers.psm1 This reduces skipped tests from 11 to ~2-3 conditional skips which is appropriate behavior for integration tests that require specific services.
Windows Test Results961 tests ±0 961 ✅ +11 26s ⏱️ ±0s Results for commit ebd22c0. ± Comparison against base commit 85955f9. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
The tests were failing because the script paths were not available during test execution when running with -TagFilter. Changed from using a foreach loop (which runs during discovery) to Pester 5's -ForEach parameter with BeforeDiscovery for proper data-driven tests.
- Add SSH agent setup step to test-scripts.yml workflow - Change -Skip parameters to Set-ItResult pattern for runtime evaluation - Tests now properly run when SSH agent is available in CI The -Skip parameter is evaluated at discovery time, but service checks need to happen at runtime. Using Set-ItResult inside the test body allows proper conditional skipping based on actual service state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-Skipfrom SupportsShouldProcess test block (feature already implemented in all 4 Tier 3 scripts)Test-NoPrivateIPsInCodehelper function to TestHelpers.psm1Test plan