Progress bar and cancelling scraper

[ecenshu]

Retrieving orderKeys prior to processing records and ScrapeOrders now uses GetOrders with a cancellation token GetOrders now implements IEnumerable which may be cancelled Use Sidebar menu to convey progress of scraping data from Humble API

Made HumbleKeysAccountClient a dependent lazy loaded instance

[Dasmius007]

@ecenshu What exactly is the reason for this feature? Is this a new Playnite feature to support showing a progress bar or the user being able to cancel? When I last spoke to the Playnite devs they said giving a progress percentage update from a library was not possible (at least in the main top progress bar that shows each library being updated). Just trying to get context for this feature change because I was unaware you were even working on it.

Also did you pull the latest code from my master branch first, and merge it with your code before submitting this PR? I'm just concerned that you keep working on your fork of the repo instead of directly on mine, and I don't want any of the changes I've made recently to get overwritten.

[ecenshu]

Your code was pulled before work was done on this. This had been a feature that I had been working on for a while but had not had a prompt to include until the issue 39 was raised about some sort of indicator so the user doesn't know what the plugin was doing.

You are correct that the top progress bar cannot be interacted with since it is actually tracking the progress of updating the Playnite Game database which occurs after the data scraping and is so fast that the user doesn't even know there was a collection operation being done. I got around this by using the only other progress bar that Playnite exposes which is on the side bar. So there are actually 2 progress bars visible during an import with my additional code.

I work on my fork before I submit a pull request as I make a mess of my commits normally and doing a squashed commit from it takes a lot of time so I prefer to make a clean feature branch after I get a successful remote build in the fork working first.

[Dasmius007]

Ahh, I see. Well that sounds cool, but I was unaware that our library even had a side bar icon. How do I enable it?

I'd like to see what it looks like now before this code is merged, so I will be able to have a before & after view with and without this new progress bar code. That way I can provide a better reply to issue #39 regarding this new feature.

[ecenshu]

I added to the existing sidebar (it only turns on during data scraping and turns off when done), there isn't one currently for the plugin. You can test this by doing a local build and setting Playnite to have the developer build point to where your bin folder is.