Push sample file to check PR#76
Conversation
senuradp
left a comment
There was a problem hiding this comment.
Good work fixing the alert-related folder structure and connecting threshold.py, alerts.py, and main.py into a runnable mock workflow. This is useful as an integration/demo contribution and helps validate how threshold logic and alert generation connect.
Before this can be merged into the final pipeline, a few alignment changes are needed:
- Please update the threshold ranges to match our final agreed system logic:
No Alert: Δr < 0.3
LOW: 0.3 ≤ Δr < 0.5
MEDIUM: 0.5 ≤ Δr < 0.7
HIGH: Δr ≥ 0.7
Currently HIGH starts at 0.8, so HIGH_THRESHOLD should be changed to 0.70.
-
Please update the import in alerts.py. Since threshold.py is inside the correlation_alert module, avoid
from threshold import get_alert_level. Use a module-safe import such as:
from correlation_alert.threshold import get_alert_level
or a relative import if appropriate. -
The current main.py uses hardcoded mock data, which is fine for testing/demo, but it should not replace the main reusable wrapper pipeline. For final integration, the alert logic should connect with the change results generated by the main correlation pipeline.
Overall, this is a useful integration fix, but it needs threshold and wrapper-format alignment before merging.
|
Thanks for updating the implementation. I reviewed the updated The file correctly imports One important note for final integration: this file currently focuses only on the alert side of the workflow. It does not replace the full correlation change alert wrapper, which still needs to handle preprocessing, rolling windows, correlation computation, change comparison, and alert generation together. Overall, this is a useful alert pipeline/demo contribution and can be used during integration as a helper or testing runner. |
No description provided.