CCA - 003: Rolling window segmentation#80
Conversation
Implemented rolling window logic and correlation computation for multi-sensor time-series data Signed-off-by: saumya dholia <saumyadholia25@gmail.com>
senuradp
left a comment
There was a problem hiding this comment.
Good work on exploring rolling window segmentation and validating it across different datasets. The approach and logic are correct and relevant for the correlation alert pipeline.
However, for integration into the project, we need this to follow the modular structure defined in the wrapper.
Please refactor your implementation into a single function:
create_rolling_windows(df, window_size, step_size)
This function should:
- take the preprocessed dataframe as input
- return a list of windowed dataframes
- avoid implementing other pipeline stages (correlation, alerts, etc.)
- avoid notebook-based execution in the final version
The notebooks are useful for experimentation, but the final PR should contain a clean Python implementation that fits into the wrapper pipeline.
Signed-off-by: saumya dholia <saumyadholia25@gmail.com>
|
uploaded the updated file |
Signed-off-by: saumya dholia <saumyadholia25@gmail.com>
|
Thanks for updating the PR based on the earlier feedback. I reviewed the updated rolling window implementation, and this version is much better aligned with the intended modular pipeline structure. The There is one minor issue to fix before final integration: the function currently resets the index inside each window using I updated: to: Overall, this is a solid rolling window implementation and is ready to proceed after this minor fix. |
Implemented rolling window logic and correlation computation for multi-sensor time-series data