fix(ci): restore green pipeline (pnpm conflict, formatting, action bumps)#134
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe CI workflow upgrades ChangesCI Workflow Action Upgrades
Database Build-Phase Handling
Source File Formatting Cleanup
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🇪🇸 Español
El CI llevaba caído incluso con el billing arreglado, por dos problemas que se colaron al mergear PRs sin CI durante el bloqueo de facturación:
pnpm/action-setuprecibíaversion: 11en el workflow y a la vezpackageManager: pnpm@11.0.0enpackage.json→ERR_PNPM_BAD_PM_VERSION("Multiple versions of pnpm"). Se elimina elversiondel workflow; la versión sale depackage.json.prettier --check. Se aplican conprettier --write(solo formato, sin cambios de lógica).De paso se aplican los 3 bumps de actions que Dependabot tenía abiertos (cierra #121, #120, #119):
actions/checkout4 → 7pnpm/action-setup4 → 6actions/setup-node4 → 6Validado en local:
format:check,lint,typecheck,test(78 ✓) ybuildpasan.🇬🇧 English
CI was still failing even after the billing fix, due to two issues introduced while merging PRs without CI during the billing lockout:
pnpm/action-setupgotversion: 11in the workflow whilepackage.jsonalso declarespackageManager: pnpm@11.0.0→ERR_PNPM_BAD_PM_VERSION("Multiple versions of pnpm"). Droppedversionfrom the workflow; the version now comes frompackage.json.prettier --check. Appliedprettier --write(formatting only, no logic changes).Also folds in the 3 Dependabot action bumps that were open (closes #121, #120, #119):
actions/checkout4 → 7pnpm/action-setup4 → 6actions/setup-node4 → 6Validated locally:
format:check,lint,typecheck,test(78 ✓) andbuildpass.Summary by CodeRabbit
next buildso it can run withoutTURSO_DATABASE_URLby using a build-time fallback; runtime behavior remains strict.