Skip to content

fix(ci): restore green pipeline (pnpm conflict, formatting, action bumps)#134

Merged
DataDave-Dev merged 3 commits into
mainfrom
fix/restore-green-ci
Jun 19, 2026
Merged

fix(ci): restore green pipeline (pnpm conflict, formatting, action bumps)#134
DataDave-Dev merged 3 commits into
mainfrom
fix/restore-green-ci

Conversation

@DataDave-Dev

@DataDave-Dev DataDave-Dev commented Jun 19, 2026

Copy link
Copy Markdown
Owner

🇪🇸 Español

El CI llevaba caído incluso con el billing arreglado, por dos problemas que se colaron al mergear PRs sin CI durante el bloqueo de facturación:

  1. Conflicto de pnpm: pnpm/action-setup recibía version: 11 en el workflow y a la vez packageManager: pnpm@11.0.0 en package.jsonERR_PNPM_BAD_PM_VERSION ("Multiple versions of pnpm"). Se elimina el version del workflow; la versión sale de package.json.
  2. Formato: 9 archivos no pasaban prettier --check. Se aplican con prettier --write (solo formato, sin cambios de lógica).

De paso se aplican los 3 bumps de actions que Dependabot tenía abiertos (cierra #121, #120, #119):

  • actions/checkout 4 → 7
  • pnpm/action-setup 4 → 6
  • actions/setup-node 4 → 6

Validado en local: format:check, lint, typecheck, test (78 ✓) y build pasan.


🇬🇧 English

CI was still failing even after the billing fix, due to two issues introduced while merging PRs without CI during the billing lockout:

  1. pnpm conflict: pnpm/action-setup got version: 11 in the workflow while package.json also declares packageManager: pnpm@11.0.0ERR_PNPM_BAD_PM_VERSION ("Multiple versions of pnpm"). Dropped version from the workflow; the version now comes from package.json.
  2. Formatting: 9 files failed prettier --check. Applied prettier --write (formatting only, no logic changes).

Also folds in the 3 Dependabot action bumps that were open (closes #121, #120, #119):

  • actions/checkout 4 → 7
  • pnpm/action-setup 4 → 6
  • actions/setup-node 4 → 6

Validated locally: format:check, lint, typecheck, test (78 ✓) and build pass.

Summary by CodeRabbit

  • Chores
    • Updated CI workflows to use newer GitHub Actions versions and streamlined pnpm setup.
  • Bug Fixes
    • Improved next build so it can run without TURSO_DATABASE_URL by using a build-time fallback; runtime behavior remains strict.
  • Refactor
    • Reworked validation and component logic formatting without changing behavior.
  • Style
    • Reformatted JSX/CSS/typings for readability and consistency.
  • Tests
    • Updated test formatting in analyzer and schema tests without altering assertions.

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b4b0e6e6-4173-45f6-8458-043287f0eeb4

📥 Commits

Reviewing files that changed from the base of the PR and between 2676567 and c94d752.

📒 Files selected for processing (1)
  • src/db/index.ts

📝 Walkthrough

Walkthrough

The CI workflow upgrades actions/checkout to v7, pnpm/action-setup to v6, and actions/setup-node to v6, replacing explicit pnpm version pinning with package.json#packageManager detection. Database client initialization now detects the build phase and uses an in-memory LibSQL fallback when TURSO_DATABASE_URL is absent during builds. The remaining changes are formatting-only reformats across validation schemas, React components, CSS, and tests with no logic or behavior modifications.

Changes

CI Workflow Action Upgrades

Layer / File(s) Summary
GitHub Actions version bumps and pnpm version detection
.github/workflows/ci.yml
Upgrades actions/checkout v4→v7, pnpm/action-setup v4→v6, and actions/setup-node v4→v6; removes explicit with.version: 11 pnpm pin and adds comments directing pnpm version resolution to package.json#packageManager.

Database Build-Phase Handling

Layer / File(s) Summary
Build-phase environment handling
src/db/index.ts
Detects build phase and uses file::memory: LibSQL URL fallback when TURSO_DATABASE_URL is absent, allowing builds to proceed without the env var while retaining runtime errors during non-build execution.

Source File Formatting Cleanup

Layer / File(s) Summary
Validation schema and test formatting
src/lib/validation.ts, src/lib/validation.test.ts
Expands graphSchema node/edge z.object(...).loose() definitions into multi-line blocks and reformats the graphMetaSchema empty-title test's safeParse input into a multi-line object literal; validation behavior and assertions unchanged.
Component and CSS formatting
src/components/layout/Header.tsx, src/components/sections/TestimonialForm.tsx, src/components/sections/TestimonialsBoard.tsx, src/components/ui/CodeWorkspace.tsx, src/components/ui/Diagram.tsx, src/app/globals.css, src/app/api/analyze/route.test.ts
Reformats JSX opening tags, ternary expressions, import statements, useCallback dependency arrays, CSS transition declarations, and test spy setups across these files; no logic, props, or assertions were changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • DataDave-Dev/weftmap#106: Implements the handleExport feature in src/components/ui/Diagram.tsx around the same document.querySelector(".react-flow__viewport") call that is reformatted here.

Poem

🐇 One workflow leap to v7's door,
Database builds when env's no more,
Long lines rest, short lines align—
Formatting dance on every line.
No logic harmed in tidy fare,
Just whitespace rearranged with care! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main fixes: restoring a failing CI pipeline by addressing pnpm conflict, formatting issues, and action version bumps.
Description check ✅ Passed The description comprehensively documents the CI issues, solutions (pnpm fix and formatting), action bumps, and local validation results in both Spanish and English.
Linked Issues check ✅ Passed The PR successfully upgrades actions/checkout from v4 to v7 [#121] and includes bumps for pnpm/action-setup v4→v6 and actions/setup-node v4→v6 [#120, #119], addressing all linked issue objectives.
Out of Scope Changes check ✅ Passed All changes are within scope: CI workflow upgrades address linked issues, pnpm version conflict fix restores pipeline, and formatting changes apply prettier to nine files that failed validation.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/restore-green-ci

Comment @coderabbitai help to get the list of available commands and usage tips.

@DataDave-Dev DataDave-Dev merged commit c237c7d into main Jun 19, 2026
1 of 2 checks passed
@DataDave-Dev DataDave-Dev deleted the fix/restore-green-ci branch June 19, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant