(No-op) SA1019: Remove deprecated functions usage

[tbavelier]

What does this PR do?

• Replaces all deprecated functions with the modern equivalent

Motivation

• Same as (No-op) Remove duplicate imports #2420 : Reduce number of staticcheck linter (disabled for now) violations

Additional Notes

Anything else we should know when reviewing?

Minimum Agent Versions

Are there minimum versions of the Datadog Agent and/or Cluster Agent required?

• Agent: vX.Y.Z
• Cluster Agent: vX.Y.Z

Describe your test plan

Tested the plugin manually, verified metrics forwarder is still working and is stopped on object removal

Checklist

• PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
• PR has a milestone or the qa/skip-qa label
• All commits are signed (see: signing commits)

[codecov-commenter]

Codecov Report

❌ Patch coverage is 21.56863% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.03%. Comparing base (d09fcb3) to head (eed36b0).

Files with missing lines	Patch %	Lines
internal/controller/datadogmonitor/controller.go	35.29%	9 Missing and 2 partials ⚠️
cmd/kubectl-datadog/flare/flare.go	0.00%	10 Missing ⚠️
cmd/kubectl-datadog/agent/check/check.go	0.00%	5 Missing ⚠️
pkg/controller/utils/datadog/metrics_forwarder.go	0.00%	4 Missing ⚠️
cmd/check-operator/upgrade/upgrade.go	0.00%	2 Missing ⚠️
cmd/helpers/secrets/secrets.go	0.00%	2 Missing ⚠️
hack/generate-docs/generate-docs.go	0.00%	1 Missing ⚠️
...al/controller/datadogagent/component_reconciler.go	0.00%	0 Missing and 1 partial ⚠️
...controller/datadogagent/controller_reconcile_v2.go	50.00%	1 Missing ⚠️
...oller/datadogagentinternal/component_reconciler.go	0.00%	1 Missing ⚠️
... and 2 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2478      +/-   ##
==========================================
- Coverage   40.05%   40.03%   -0.03%     
==========================================
  Files         319      319              
  Lines       28052    28066      +14     
==========================================
- Hits        11237    11235       -2     
- Misses      15993    16008      +15     
- Partials      822      823       +1     

Flag	Coverage Δ
unittests	40.03% <21.56%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
internal/controller/datadogagent/merger/service.go	68.42% <100.00%> (ø)
internal/controller/datadogdashboard/controller.go	50.00% <100.00%> (ø)
...al/controller/datadoggenericresource/controller.go	53.17% <100.00%> (ø)
internal/controller/datadogslo/controller.go	59.88% <100.00%> (ø)
hack/generate-docs/generate-docs.go	0.00% <0.00%> (ø)
...al/controller/datadogagent/component_reconciler.go	71.71% <0.00%> (ø)
...controller/datadogagent/controller_reconcile_v2.go	61.00% <50.00%> (ø)
...oller/datadogagentinternal/component_reconciler.go	0.00% <0.00%> (ø)
...er/datadogagentinternal/controller_reconcile_v2.go	0.00% <0.00%> (ø)
pkg/controller/utils/shared_utils.go	0.00% <0.00%> (ø)
... and 6 more

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d09fcb3...eed36b0. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[datadog-datadog-prod-us1-2]

❌ Code Coverage

✨ Fix all issues with BitsAI

🛑 Gate Violations

🎯 1 Code Coverage issue detected

A Patch coverage percentage gate may be blocking this PR.

• Patch coverage: 20.45% (threshold: 80.00%)

ℹ️ Info

🎯 Code Coverage (details)
• Patch Coverage: 20.45%
• Overall Coverage: 40.11% (-0.03%)

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: eed36b0 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!}