[V2] feat: Handle wrapped onPress event in DdEventsInterceptor for react-native-ui-lib compatibility#1165
Closed
sbarrio wants to merge 623 commits intofeature/v2from
Closed
[V2] feat: Handle wrapped onPress event in DdEventsInterceptor for react-native-ui-lib compatibility#1165sbarrio wants to merge 623 commits intofeature/v2from
sbarrio wants to merge 623 commits intofeature/v2from
Conversation
add account info to `applyEventMapper`
Preserve user baggage header when setting session ID Enforced W3 specification for 'baggage' header Only inject Session ID header if propagator=Datadog|W3C Additional test for baggage header and minor warn message improvement
Revert "FFL-900 Flags SDK" Co-authored-by: yugisu-flux <86969397+yugisu-flux@users.noreply.github.com> Co-authored-by: dmytrii.puzyr <dmytrii.puzyr@datadoghq.com>
[RELEASE] React Native SDK v3.0.3
…-1092-feature/flags
[FIX] Fix SDK compilation errors
…flags' into dima/readable-errors-in-flags-sdk
Update error messages to be more readable in the iOS Flags SDK
…/flags FFL-900 Reintroduce Flags SDK
…-comments [CHORE] Update OpenFeature README
[RELEASE] React Native SDK v3.1.0
…dule-fix-for-3.5.0 [Fix][Benchmarks] Missing sdkCore when creating DatadogVitalsMeter
…itals-collection-to-3.5.0 [Fix][Benchmarks] Update iOS Benchmark Vitals to be compatible with native iOS SDK v3.5.0
[FIX] Missing events in Expo caused by wrong singleton usage
Some third-party libraries (e.g. react-native-ui-lib) change the onPress
callback signature by wrapping the native GestureResponderEvent inside a
props object: onPress({...componentProps, event: GestureResponderEvent}).
The SDK checks args[0]._targetInst to identify the tapped element, which
only exists on the native event — not on the wrapper object — causing
actions to be silently dropped.
This adds a fallback in DdEventsInterceptor.interceptOnPress that checks
args[0].event._targetInst when args[0]._targetInst is not present,
allowing the SDK to extract the native event from the wrapper.
sbarrio
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Clone of #1164 aimed towards
feature/v2