[CHORE] Fix Issue Notification action to use OPENAI_MODEL env var#1177
Open
[CHORE] Fix Issue Notification action to use OPENAI_MODEL env var#1177
Conversation
mariedm
previously approved these changes
Mar 5, 2026
mariedm
previously approved these changes
Mar 5, 2026
estherk15
previously approved these changes
Mar 5, 2026
04f6565 to
9a12918
Compare
mariedm
approved these changes
Mar 6, 2026
| OPENAI_SYSTEM_PROMPT: ${{ vars.OPENAI_SYSTEM_PROMPT }} | ||
| OPENAI_MODEL: ${{ vars.OPENAI_MODEL }} | ||
| OPENAI_TEMPERATURE: ${{ vars.OPENAI_TEMPERATURE }} | ||
| OPENAI_MAX_COMPLETION_TOKENS: ${{ vars.OPENAI_MAX_COMPLETION_TOKENS }} |
Member
There was a problem hiding this comment.
nit: we could have kept the env var name the same and only update the param sent when calling the API
Contributor
Author
There was a problem hiding this comment.
I initially did that, yes. But I think it could be very easy to forget why we did that change down the lane so I opted to properly rename it all.
estherk15
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the issue_notification Github action with the following changes:
max_completion_tokenstemperatureparameter as it is now available on the current model set.Review checklist (to be filled by reviewers)