Skip to content

[CHORE] Fix Issue Notification action to use OPENAI_MODEL env var#1177

Open
sbarrio wants to merge 1 commit intodevelopfrom
sbarrio/fix/update-default-model-for-issue-notification-action
Open

[CHORE] Fix Issue Notification action to use OPENAI_MODEL env var#1177
sbarrio wants to merge 1 commit intodevelopfrom
sbarrio/fix/update-default-model-for-issue-notification-action

Conversation

@sbarrio
Copy link
Contributor

@sbarrio sbarrio commented Mar 5, 2026

What does this PR do?

This PR updates the issue_notification Github action with the following changes:

  • Properly read the OPENAI_MODEL env variable, which was being ignored before. It also sets a new default model in case it was not provided.
  • Updated the openai dependency to 2.17.0
  • Changes OPENAI_MAX_RESPONSE_TOKENS into OPENAI_MAX_COMPLETION_TOKENS to be used setting max_completion_tokens
  • Does not pass the temperature parameter as it is now available on the current model set.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

mariedm
mariedm previously approved these changes Mar 5, 2026
@sbarrio sbarrio marked this pull request as ready for review March 5, 2026 16:42
@sbarrio sbarrio requested review from a team as code owners March 5, 2026 16:42
@sbarrio sbarrio requested a review from mariedm March 5, 2026 16:42
mariedm
mariedm previously approved these changes Mar 5, 2026
estherk15
estherk15 previously approved these changes Mar 5, 2026
@sbarrio sbarrio had a problem deploying to protected-dev-env March 5, 2026 19:52 — with GitHub Actions Failure
@sbarrio sbarrio had a problem deploying to protected-dev-env March 5, 2026 19:53 — with GitHub Actions Failure
@sbarrio sbarrio dismissed stale reviews from estherk15 and mariedm via 3dcf198 March 6, 2026 11:35
@sbarrio sbarrio had a problem deploying to protected-dev-env March 6, 2026 11:35 — with GitHub Actions Failure
@sbarrio sbarrio had a problem deploying to protected-dev-env March 6, 2026 11:37 — with GitHub Actions Failure
@sbarrio sbarrio temporarily deployed to protected-dev-env March 6, 2026 11:48 — with GitHub Actions Inactive
@sbarrio sbarrio force-pushed the sbarrio/fix/update-default-model-for-issue-notification-action branch from 04f6565 to 9a12918 Compare March 6, 2026 11:50
@sbarrio sbarrio requested review from estherk15 and mariedm March 6, 2026 11:52
@sbarrio sbarrio deployed to protected-dev-env March 6, 2026 11:54 — with GitHub Actions Active
@sbarrio sbarrio self-assigned this Mar 6, 2026
OPENAI_SYSTEM_PROMPT: ${{ vars.OPENAI_SYSTEM_PROMPT }}
OPENAI_MODEL: ${{ vars.OPENAI_MODEL }}
OPENAI_TEMPERATURE: ${{ vars.OPENAI_TEMPERATURE }}
OPENAI_MAX_COMPLETION_TOKENS: ${{ vars.OPENAI_MAX_COMPLETION_TOKENS }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we could have kept the env var name the same and only update the param sent when calling the API

Copy link
Contributor Author

@sbarrio sbarrio Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially did that, yes. But I think it could be very easy to forget why we did that change down the lane so I opted to properly rename it all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants