Closed
Conversation
Collaborator
|
Closing because it's been implemented in #214. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for the DD_EXTERNAL_ENV, DD_ENTITY_ID and DD_CONTAINER_ID configurables
Motivation
Other implementations, such as dd-trace-py, already support these, which help with running tracing from containerized
environments. The Datadog Admission Controller sets DD_EXTERNAL_ENV and DD_ENTITY_ID, and the DD_CONTAINER_ID can be provided by the user if he has previously discovered the ID using an external script.
Additional Notes
container-id.shis added toexamples/containershowing how to populateDD_CONTAINER_ID, based on existing code from other Datadog libraries in Python.dd-trace-pyand some cursory glancing atdatadog-agent. I may have got things wrong. For instance,dd-trace-pysets aDatadog-Entity-IDheader (in addtion to the tag) while the agent does not parse any such header, so we skip setting that header in this implementation.dd-trace-py, not any official internal specificationsJira ticket: [PROJ-IDENT]