Skip to content

chore(ci): pin cmake version#201

Merged
dmehala merged 1 commit intomainfrom
dmehala/chore/ci
Apr 2, 2025
Merged

chore(ci): pin cmake version#201
dmehala merged 1 commit intomainfrom
dmehala/chore/ci

Conversation

@dmehala
Copy link
Copy Markdown
Collaborator

@dmehala dmehala commented Apr 2, 2025

Description

The CI started fails recently because chocolatey and ubuntu-latest install the latest version of CMake (4.0.0), which remove compatibility with CMake < 3.5. Until we update the CMake version (and because it's good pratice), pin the version of CMake to 3.31.6 which is still compatible with 3.5 and older.

Changes:

  • Add a new cmake preset for codeql.

@dmehala dmehala requested a review from a team as a code owner April 2, 2025 10:37
@dmehala dmehala requested review from zacharycmontoya and removed request for a team April 2, 2025 10:37
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.15%. Comparing base (be57fe9) to head (b743536).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #201   +/-   ##
=======================================
  Coverage   93.15%   93.15%           
=======================================
  Files          76       76           
  Lines        4471     4471           
=======================================
  Hits         4165     4165           
  Misses        306      306           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Apr 2, 2025

Benchmarks

Benchmark execution time: 2025-04-02 10:52:36

Comparing candidate commit b743536 in PR branch dmehala/chore/ci with baseline commit be57fe9 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@dmehala dmehala force-pushed the dmehala/chore/ci branch from 8f70a8d to 4b4f900 Compare April 2, 2025 10:47
@dmehala dmehala changed the title chore(windows-ci): pin cmake version chore(ci): pin cmake version Apr 2, 2025
@dmehala dmehala force-pushed the dmehala/chore/ci branch from 4b4f900 to b743536 Compare April 2, 2025 10:49
@dmehala dmehala merged commit c714a42 into main Apr 2, 2025
22 checks passed
@dmehala dmehala deleted the dmehala/chore/ci branch April 2, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants