[part 7] refactor!(telemetry): improve telemetry lifecycle#205
Merged
Conversation
9b18a67 to
2907ec4
Compare
Changes: - add support for install_signature. - add support for product in configuration that will be reported in app-started message. - unit tests
2907ec4 to
7f2a7f2
Compare
BenchmarksBenchmark execution time: 2025-04-10 12:13:26 Comparing candidate commit 2a257ea in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
- Coverage 90.21% 89.67% -0.55%
==========================================
Files 79 80 +1
Lines 4672 4705 +33
==========================================
+ Hits 4215 4219 +4
- Misses 457 486 +29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pablomartinezbernardo
approved these changes
Apr 9, 2025
Co-authored-by: pablomartinezbernardo <134320516+pablomartinezbernardo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now, telemetry module follows RAII. The
app-startedevent is emitted only at the construction of the module while theapp-closingevent is emitted at the destruction of the module. This enforce the telemetry specs.Changes:
For reference:
DatadogAgent#194TracerTelemetry#204