fix(curl): enforce drain to clear in-flight requests#215
Merged
Conversation
dmehala
requested review from
a team,
dubloom and
pablomartinezbernardo
and removed request for
a team
dmehala
changed the title
pablomartinezbernardo
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the issue reported in #213.
What's going on?
Root Cause
make_telemetryinitializes aTelemetryobject, which is then "moved" via the move constructor. During construction, theTelemetryconstructor makes an asynchronous HTTP request for theapp-startedevent.If this request is not processed before the move occurs, the lambda callback associated with the request reference the original (now-invalid) object. This results in a dangling pointer access and leads to a crash 💥.
Fix
The fix enhance the drain mechanism by canceling/removing requests in-flight. This ensures that any in-flight requests are resolved or cleared before the object is moved or destroyed, avoiding use-after-move scenarios.