chore: report codeowners to test optimization#245
Merged
Conversation
dmehala
requested review from
Anilm3,
cbeauchesne and
zacharycmontoya
and removed request for
a team
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
=======================================
Coverage 87.54% 87.54%
=======================================
Files 83 83
Lines 5468 5468
=======================================
Hits 4787 4787
Misses 681 681 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎯 Code Coverage 🔗 Commit SHA: 9f3d06b | Docs | Was this helpful? Give us feedback! |
| run: | | ||
| curl -L --fail "https://github.com/DataDog/datadog-ci/releases/latest/download/datadog-ci_linux-${{ matrix.arch }}" --output "/usr/local/bin/datadog-ci" && chmod +x /usr/local/bin/datadog-ci | ||
| datadog-ci junit upload --service dd-trace-cpp .build/report.xml | ||
| datadog-ci junit upload --service dd-trace-cpp --tags test.source.file:test/*.cpp .build/report.xml |
Contributor
There was a problem hiding this comment.
I though that datadog-ci junit upload was correctly resolving owners if it found a .github/codewoners file. For my knowledge, do you know why it needs this tag here ?
Collaborator
Author
There was a problem hiding this comment.
CODEOWNERS is partially supported for junit-xml. It properly tags if the XML report has the test.source.file field. Unfortunately, it seems catch2 doesn't support this field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.