Skip to content

fix(cmake): replace remaining targets depending on dd_trace_cpp-static#249

Merged
dmehala merged 1 commit intomainfrom
dmehala/fix-dd-trace-cpp-targets
Oct 14, 2025
Merged

fix(cmake): replace remaining targets depending on dd_trace_cpp-static#249
dmehala merged 1 commit intomainfrom
dmehala/fix-dd-trace-cpp-targets

Conversation

@dmehala
Copy link
Copy Markdown
Collaborator

@dmehala dmehala commented Oct 14, 2025

Description

Fix regression introduced in 6e5c32e

Motivation

Additional Notes

Jira ticket: [PROJ-IDENT]

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Oct 14, 2025

Benchmarks

Benchmark execution time: 2025-10-14 16:12:54

Comparing candidate commit 29905c8 in PR branch dmehala/fix-dd-trace-cpp-targets with baseline commit 6e5c32e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.62%. Comparing base (6e5c32e) to head (29905c8).
⚠️ Report is 42 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #249   +/-   ##
=======================================
  Coverage   87.62%   87.62%           
=======================================
  Files          83       83           
  Lines        5502     5502           
=======================================
  Hits         4821     4821           
  Misses        681      681           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@datadog-official
Copy link
Copy Markdown

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 87.62% (+0.00%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 29905c8 | Docs | Was this helpful? Give us feedback!

@dmehala dmehala changed the title fix(cmake): replace remaning targets depending on dd_trace_cpp-static fix(cmake): replace remaining targets depending on dd_trace_cpp-static Oct 14, 2025
@dmehala dmehala merged commit 286d0e3 into main Oct 14, 2025
24 checks passed
@dmehala dmehala deleted the dmehala/fix-dd-trace-cpp-targets branch October 14, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants