Skip to content

feat: send knuth sampling rates tags#250

Merged
dmehala merged 2 commits intomainfrom
dmehala/knuth-sampling-tags
Oct 21, 2025
Merged

feat: send knuth sampling rates tags#250
dmehala merged 2 commits intomainfrom
dmehala/knuth-sampling-tags

Conversation

@dmehala
Copy link
Copy Markdown
Collaborator

@dmehala dmehala commented Oct 16, 2025

Description

feat: send knuth sampling rates tags

Changes:

  • Set _dd.p.ksr tag with the knuth sampling rates computed.
  • Remove remaining devs from sampling delegation.
  • Add unit tests.

@dmehala dmehala requested a review from a team as a code owner October 16, 2025 12:28
@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Oct 16, 2025

Benchmarks

Benchmark execution time: 2025-10-16 15:19:57

Comparing candidate commit 5e4e95d in PR branch dmehala/knuth-sampling-tags with baseline commit 286d0e3 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

Changes:
  - Set `_dd.p.ksr` tag with the knuth sampling rates computed.
  - Remove remaining devs from sampling delegation.
  - Add unit tests.
@dmehala dmehala force-pushed the dmehala/knuth-sampling-tags branch from dd7e23c to 5e4e95d Compare October 16, 2025 15:16
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.65%. Comparing base (286d0e3) to head (d501c4f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   87.62%   87.65%   +0.03%     
==========================================
  Files          83       83              
  Lines        5502     5501       -1     
==========================================
+ Hits         4821     4822       +1     
+ Misses        681      679       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@datadog-datadog-prod-us1
Copy link
Copy Markdown

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 87.66% (+0.03%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d501c4f | Docs | Was this helpful? Give us feedback!

@dmehala dmehala merged commit 0c13dba into main Oct 21, 2025
26 of 27 checks passed
@dmehala dmehala deleted the dmehala/knuth-sampling-tags branch October 21, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants