Split IDuckTypeTask into separate Task and ValueTask duck types by bouwkast · Pull Request #8389 · DataDog/dd-trace-dotnet

bouwkast · 2026-03-30T19:57:10Z

Summary of changes

Create IDuckTypeValueTask<T> / IDuckTypeValueTask for ValueTask targets, and re-add TaskStatus Status to IDuckTypeTask for Task targets. Update XUnit V3 to use the ValueTask variant.

Reason for change

This is a follow up to #8366 in which Kafka was failing on .NET Framework due to not having access to the IsCompletedSuccessfully property on the Task. Initially, I attempted to swap to use a TaskStatus Status instead, but that then caused the xUnit integration tests to start failing as they are actually ValueTask and not Task which ValueTask lack the TaskStatus

Implementation details

Add TaskStatus to the IDuckTask/IDuckTask<T>
Create IValueTaskDuck/IValueTaskDuck<T> with IsCompletedSuccessfully
Update the xUnit (V3) integration to use IValueTaskDuck
Update the KafkaHelper to use TaskStatus

Test coverage

Other details

#8366

bouwkast · 2026-03-30T19:57:33Z

@codex review

chatgpt-codex-connector · 2026-03-30T19:57:46Z

To use Codex here, create a Codex account and connect to github.

pr-commenter · 2026-03-30T20:38:08Z

Benchmarks

Benchmark execution time: 2026-03-30 20:38:05

Comparing candidate commit 8d69c1c in PR branch steven/task-vs-valuetask-duck with baseline commit f51d779 in branch master.

Found 7 performance improvements and 11 performance regressions! Performance is the same for 258 metrics, 12 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

🟩 = significantly better candidate vs. baseline
🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

🟩 throughput [+8677.347op/s; +9077.256op/s] or [+7.135%; +7.464%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

🟥 execution_time [+17.741ms; +24.234ms] or [+8.954%; +12.232%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

🟥 execution_time [+19.402ms; +19.964ms] or [+10.739%; +11.051%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1

🟩 execution_time [-61.094µs; -24.530µs] or [-12.556%; -5.042%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

🟩 execution_time [-57.414ms; -50.545ms] or [-26.599%; -23.417%]

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

🟩 execution_time [-27.689ms; -21.096ms] or [-16.403%; -12.498%]
🟩 throughput [+86.122op/s; +148.928op/s] or [+6.004%; +10.383%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

🟥 execution_time [+180.210µs; +186.484µs] or [+9.420%; +9.748%]
🟥 throughput [-46.471op/s; -44.953op/s] or [-8.890%; -8.600%]

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

🟥 throughput [-45092.658op/s; -33944.351op/s] or [-8.436%; -6.350%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472

🟥 throughput [-18182.348op/s; -16582.337op/s] or [-7.085%; -6.462%]

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

🟥 execution_time [+11.083ms; +16.540ms] or [+5.550%; +8.283%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

🟥 allocated_mem [+17.606KB; +17.633KB] or [+6.826%; +6.836%]

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

🟥 execution_time [+32.833ms; +34.579ms] or [+20.440%; +21.527%]

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

🟥 throughput [-16793541.538op/s; -15213092.564op/s] or [-6.975%; -6.318%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

🟩 execution_time [-23.576ms; -18.321ms] or [-10.898%; -8.469%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

🟩 execution_time [-17.917ms; -13.112ms] or [-8.445%; -6.180%]

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

🟥 execution_time [+10.231ms; +14.137ms] or [+5.190%; +7.171%]

dd-trace-dotnet-ci-bot · 2026-03-30T21:02:01Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8389) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	71.65 ± (71.82 - 72.11) ms	71.84 ± (71.88 - 72.18) ms	+0.3%	✅⬆️
.NET Framework 4.8 - Bailout
duration	76.17 ± (75.97 - 76.33) ms	76.37 ± (76.15 - 76.51) ms	+0.3%	✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1072.42 ± (1075.06 - 1081.86) ms	1076.37 ± (1078.98 - 1087.94) ms	+0.4%	✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms	22.34 ± (22.30 - 22.37) ms	22.23 ± (22.19 - 22.27) ms	-0.5%	✅
process.time_to_main_ms	83.18 ± (83.00 - 83.37) ms	82.90 ± (82.73 - 83.06) ms	-0.3%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.93 ± (10.92 - 10.93) MB	10.90 ± (10.90 - 10.91) MB	-0.2%	✅
runtime.dotnet.threads.count	12 ± (12 - 12)	12 ± (12 - 12)	+0.0%	✅
.NET Core 3.1 - Bailout
process.internal_duration_ms	22.29 ± (22.26 - 22.33) ms	22.17 ± (22.15 - 22.20) ms	-0.5%	✅
process.time_to_main_ms	84.31 ± (84.10 - 84.51) ms	84.22 ± (84.00 - 84.45) ms	-0.1%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.96 ± (10.96 - 10.97) MB	10.94 ± (10.93 - 10.94) MB	-0.3%	✅
runtime.dotnet.threads.count	13 ± (13 - 13)	13 ± (13 - 13)	+0.0%	✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	223.68 ± (222.31 - 225.05) ms	223.39 ± (222.27 - 224.52) ms	-0.1%	✅
process.time_to_main_ms	531.77 ± (530.27 - 533.27) ms	534.40 ± (532.85 - 535.95) ms	+0.5%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	48.34 ± (48.31 - 48.37) MB	48.26 ± (48.22 - 48.29) MB	-0.2%	✅
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	+0.2%	✅⬆️
.NET 6 - Baseline
process.internal_duration_ms	21.06 ± (21.02 - 21.09) ms	20.89 ± (20.86 - 20.93) ms	-0.8%	✅
process.time_to_main_ms	72.51 ± (72.33 - 72.68) ms	71.72 ± (71.57 - 71.88) ms	-1.1%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.63 ± (10.62 - 10.63) MB	10.63 ± (10.63 - 10.63) MB	+0.0%	✅⬆️
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 6 - Bailout
process.internal_duration_ms	20.93 ± (20.90 - 20.96) ms	20.87 ± (20.83 - 20.90) ms	-0.3%	✅
process.time_to_main_ms	73.38 ± (73.20 - 73.56) ms	72.90 ± (72.72 - 73.08) ms	-0.7%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	10.74 ± (10.73 - 10.74) MB	10.74 ± (10.73 - 10.74) MB	+0.0%	✅⬆️
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	388.09 ± (385.80 - 390.39) ms	383.45 ± (381.04 - 385.86) ms	-1.2%	✅
process.time_to_main_ms	531.60 ± (530.43 - 532.76) ms	531.41 ± (530.34 - 532.49) ms	-0.0%	✅
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	50.32 ± (50.29 - 50.35) MB	50.29 ± (50.27 - 50.32) MB	-0.1%	✅
runtime.dotnet.threads.count	28 ± (28 - 28)	28 ± (28 - 28)	-0.5%	✅
.NET 8 - Baseline
process.internal_duration_ms	19.20 ± (19.16 - 19.23) ms	19.35 ± (19.31 - 19.39) ms	+0.8%	✅⬆️
process.time_to_main_ms	71.51 ± (71.34 - 71.67) ms	72.14 ± (71.98 - 72.29) ms	+0.9%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.70 ± (7.69 - 7.70) MB	7.69 ± (7.68 - 7.69) MB	-0.1%	✅
runtime.dotnet.threads.count	10 ± (10 - 10)	10 ± (10 - 10)	+0.0%	✅
.NET 8 - Bailout
process.internal_duration_ms	19.31 ± (19.27 - 19.35) ms	19.35 ± (19.30 - 19.39) ms	+0.2%	✅⬆️
process.time_to_main_ms	72.94 ± (72.80 - 73.08) ms	73.34 ± (73.19 - 73.50) ms	+0.6%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	7.76 ± (7.76 - 7.77) MB	7.73 ± (7.72 - 7.73) MB	-0.5%	✅
runtime.dotnet.threads.count	11 ± (11 - 11)	11 ± (11 - 11)	+0.0%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	307.20 ± (305.03 - 309.37) ms	308.33 ± (306.25 - 310.40) ms	+0.4%	✅⬆️
process.time_to_main_ms	491.14 ± (490.32 - 491.96) ms	492.02 ± (491.07 - 492.97) ms	+0.2%	✅⬆️
runtime.dotnet.exceptions.count	0 ± (0 - 0)	0 ± (0 - 0)	+0.0%	✅
runtime.dotnet.mem.committed	37.27 ± (37.25 - 37.29) MB	37.24 ± (37.22 - 37.26) MB	-0.1%	✅
runtime.dotnet.threads.count	27 ± (27 - 27)	27 ± (27 - 27)	-0.0%	✅

HttpMessageHandler

Metric	Master (Mean ± 95% CI)	Current (Mean ± 95% CI)	Change	Status
.NET Framework 4.8 - Baseline
duration	213.25 ± (213.22 - 214.15) ms	213.51 ± (213.28 - 214.28) ms	+0.1%	✅⬆️
.NET Framework 4.8 - Bailout
duration	216.55 ± (216.28 - 217.36) ms	217.12 ± (216.71 - 217.35) ms	+0.3%	✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration	1256.51 ± (1254.71 - 1261.23) ms	1238.66 ± (1237.99 - 1245.56) ms	-1.4%	✅
.NET Core 3.1 - Baseline
process.internal_duration_ms	209.08 ± (208.56 - 209.61) ms	205.95 ± (205.45 - 206.46) ms	-1.5%	✅
process.time_to_main_ms	90.94 ± (90.66 - 91.23) ms	89.51 ± (89.18 - 89.85) ms	-1.6%	✅
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	15.94 ± (15.92 - 15.97) MB	16.05 ± (16.03 - 16.07) MB	+0.7%	✅⬆️
runtime.dotnet.threads.count	20 ± (20 - 20)	20 ± (20 - 20)	-0.3%	✅
.NET Core 3.1 - Bailout
process.internal_duration_ms	209.89 ± (209.33 - 210.45) ms	208.30 ± (207.77 - 208.83) ms	-0.8%	✅
process.time_to_main_ms	93.12 ± (92.85 - 93.40) ms	92.12 ± (91.86 - 92.39) ms	-1.1%	✅
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	15.93 ± (15.91 - 15.95) MB	16.01 ± (15.99 - 16.03) MB	+0.5%	✅⬆️
runtime.dotnet.threads.count	21 ± (21 - 21)	21 ± (21 - 21)	-0.2%	✅
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms	422.87 ± (421.50 - 424.23) ms	422.15 ± (420.76 - 423.55) ms	-0.2%	✅
process.time_to_main_ms	571.47 ± (569.88 - 573.07) ms	571.81 ± (570.24 - 573.38) ms	+0.1%	✅⬆️
runtime.dotnet.exceptions.count	3 ± (3 - 3)	3 ± (3 - 3)	+0.0%	✅
runtime.dotnet.mem.committed	59.04 ± (58.99 - 59.09) MB	59.15 ± (59.10 - 59.19) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (30 - 30)	-0.3%	✅
.NET 6 - Baseline
process.internal_duration_ms	215.96 ± (215.43 - 216.49) ms	214.25 ± (213.79 - 214.71) ms	-0.8%	✅
process.time_to_main_ms	79.87 ± (79.57 - 80.17) ms	79.36 ± (79.13 - 79.59) ms	-0.6%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.18 ± (16.16 - 16.21) MB	16.21 ± (16.19 - 16.23) MB	+0.2%	✅⬆️
runtime.dotnet.threads.count	20 ± (19 - 20)	20 ± (19 - 20)	-0.1%	✅
.NET 6 - Bailout
process.internal_duration_ms	214.57 ± (214.07 - 215.07) ms	211.48 ± (210.95 - 212.00) ms	-1.4%	✅
process.time_to_main_ms	80.80 ± (80.54 - 81.06) ms	79.48 ± (79.26 - 79.70) ms	-1.6%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	16.25 ± (16.22 - 16.27) MB	16.23 ± (16.20 - 16.26) MB	-0.1%	✅
runtime.dotnet.threads.count	21 ± (20 - 21)	20 ± (20 - 21)	-0.2%	✅
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms	598.71 ± (596.16 - 601.26) ms	598.63 ± (596.07 - 601.19) ms	-0.0%	✅
process.time_to_main_ms	576.99 ± (575.60 - 578.37) ms	570.27 ± (568.92 - 571.63) ms	-1.2%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	61.45 ± (61.35 - 61.55) MB	61.73 ± (61.62 - 61.84) MB	+0.5%	✅⬆️
runtime.dotnet.threads.count	31 ± (31 - 31)	31 ± (31 - 31)	+0.1%	✅⬆️
.NET 8 - Baseline
process.internal_duration_ms	211.90 ± (211.39 - 212.40) ms	210.45 ± (209.97 - 210.93) ms	-0.7%	✅
process.time_to_main_ms	78.51 ± (78.24 - 78.77) ms	78.14 ± (77.91 - 78.37) ms	-0.5%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.61 ± (11.59 - 11.63) MB	11.60 ± (11.58 - 11.62) MB	-0.1%	✅
runtime.dotnet.threads.count	19 ± (19 - 19)	19 ± (19 - 19)	-0.0%	✅
.NET 8 - Bailout
process.internal_duration_ms	211.73 ± (211.18 - 212.29) ms	209.49 ± (209.12 - 209.86) ms	-1.1%	✅
process.time_to_main_ms	79.37 ± (79.14 - 79.59) ms	79.06 ± (78.86 - 79.26) ms	-0.4%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	11.59 ± (11.57 - 11.61) MB	11.66 ± (11.64 - 11.68) MB	+0.6%	✅⬆️
runtime.dotnet.threads.count	20 ± (20 - 20)	20 ± (20 - 20)	-0.3%	✅
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms	563.52 ± (555.81 - 571.23) ms	562.70 ± (555.00 - 570.40) ms	-0.1%	✅
process.time_to_main_ms	529.53 ± (528.52 - 530.55) ms	525.14 ± (524.08 - 526.20) ms	-0.8%	✅
runtime.dotnet.exceptions.count	4 ± (4 - 4)	4 ± (4 - 4)	+0.0%	✅
runtime.dotnet.mem.committed	51.36 ± (51.26 - 51.46) MB	51.38 ± (51.28 - 51.48) MB	+0.0%	✅⬆️
runtime.dotnet.threads.count	30 ± (30 - 30)	30 ± (30 - 30)	+0.1%	✅⬆️

Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts

FakeDbCommand (.NET Framework 4.8)

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8389) - mean (72ms)  : 70, 74
    master - mean (72ms)  : 70, 74

    section Bailout
    This PR (8389) - mean (76ms)  : 75, 78
    master - mean (76ms)  : 74, 78

    section CallTarget+Inlining+NGEN
    This PR (8389) - mean (1,083ms)  : 1019, 1148
    master - mean (1,078ms)  : 1030, 1127

FakeDbCommand (.NET Core 3.1)

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8389) - mean (112ms)  : 108, 115
    master - mean (112ms)  : 108, 116

    section Bailout
    This PR (8389) - mean (113ms)  : 110, 116
    master - mean (113ms)  : 110, 116

    section CallTarget+Inlining+NGEN
    This PR (8389) - mean (796ms)  : 779, 814
    master - mean (795ms)  : 778, 812

FakeDbCommand (.NET 6)

gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8389) - mean (99ms)  : 96, 102
    master - mean (100ms)  : 95, 105

    section Bailout
    This PR (8389) - mean (100ms)  : 97, 103
    master - mean (100ms)  : 98, 103

    section CallTarget+Inlining+NGEN
    This PR (8389) - mean (944ms)  : 901, 986
    master - mean (948ms)  : 907, 989

FakeDbCommand (.NET 8)

gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8389) - mean (99ms)  : 95, 103
    master - mean (98ms)  : 95, 102

    section Bailout
    This PR (8389) - mean (101ms)  : 98, 103
    master - mean (100ms)  : 97, 102

    section CallTarget+Inlining+NGEN
    This PR (8389) - mean (831ms)  : 791, 871
    master - mean (829ms)  : 795, 862

HttpMessageHandler (.NET Framework 4.8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8389) - mean (214ms)  : 208, 220
    master - mean (214ms)  : 209, 219

    section Bailout
    This PR (8389) - mean (217ms)  : 214, 220
    master - mean (217ms)  : 211, 223

    section CallTarget+Inlining+NGEN
    This PR (8389) - mean (1,242ms)  : 1186, 1297
    master - mean (1,258ms)  : 1211, 1305

HttpMessageHandler (.NET Core 3.1)

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8389) - mean (305ms)  : 298, 312
    master - mean (310ms)  : 303, 316

    section Bailout
    This PR (8389) - mean (310ms)  : 303, 317
    master - mean (312ms)  : 305, 320

    section CallTarget+Inlining+NGEN
    This PR (8389) - mean (1,038ms)  : 1013, 1063
    master - mean (1,035ms)  : 1001, 1070

HttpMessageHandler (.NET 6)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8389) - mean (302ms)  : 293, 312
    master - mean (305ms)  : 296, 315

    section Bailout
    This PR (8389) - mean (300ms)  : 294, 306
    master - mean (304ms)  : 298, 310

    section CallTarget+Inlining+NGEN
    This PR (8389) - mean (1,200ms)  : 1164, 1236
    master - mean (1,205ms)  : 1169, 1242

HttpMessageHandler (.NET 8)

gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8389) - mean (299ms)  : 291, 307
    master - mean (301ms)  : 291, 311

    section Bailout
    This PR (8389) - mean (299ms)  : 294, 305
    master - mean (302ms)  : 294, 310

    section CallTarget+Inlining+NGEN
    This PR (8389) - mean (1,128ms)  : 1000, 1255
    master - mean (1,127ms)  : 1013, 1241

bouwkast added 2 commits March 30, 2026 15:38

Split IDuckTypeTask into separate Task and ValueTask duck types

0ad39cb

Update KafkaHelper to use the new TaskStatus

8d69c1c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Split IDuckTypeTask into separate Task and ValueTask duck types#8389

Split IDuckTypeTask into separate Task and ValueTask duck types#8389
bouwkast wants to merge 2 commits intomasterfrom
steven/task-vs-valuetask-duck

bouwkast commented Mar 30, 2026

Uh oh!

bouwkast commented Mar 30, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 30, 2026

Uh oh!

pr-commenter bot commented Mar 30, 2026

Explanation

More details about the CI and significant changes

Uh oh!

dd-trace-dotnet-ci-bot bot commented Mar 30, 2026

FakeDbCommand

HttpMessageHandler

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

bouwkast commented Mar 30, 2026

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

bouwkast commented Mar 30, 2026

Uh oh!

chatgpt-codex-connector bot commented Mar 30, 2026

Uh oh!

pr-commenter bot commented Mar 30, 2026

Benchmarks

Explanation

More details about the CI and significant changes

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net472

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody net6.0

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmark netcoreapp3.1

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

scenario:Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces netcoreapp3.1

scenario:Benchmarks.Trace.CharSliceBenchmark.OriginalCharSlice net6.0

scenario:Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync net6.0

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net472

scenario:Benchmarks.Trace.ILoggerBenchmark.EnrichedLog net6.0

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

scenario:Benchmarks.Trace.Log4netBenchmark.EnrichedLog netcoreapp3.1

scenario:Benchmarks.Trace.SingleSpanAspNetCoreBenchmark.SingleSpanAspNetCore netcoreapp3.1

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes netcoreapp3.1

scenario:Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin netcoreapp3.1

Uh oh!

dd-trace-dotnet-ci-bot bot commented Mar 30, 2026

Execution-Time Benchmarks Report ⏱️

FakeDbCommand

HttpMessageHandler

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant