Skip to content

fix(gorm): respect DD_TRACE_REMOVE_INTEGRATION_SERVICE_NAMES_ENABLED #4579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guipace wants to merge 2 commits into from
Closed

fix(gorm): respect DD_TRACE_REMOVE_INTEGRATION_SERVICE_NAMES_ENABLED #4579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e74c39
fix(gorm): respect DD_TRACE_REMOVE_INTEGRATION_SERVICE_NAMES_ENABLED
guipace Mar 20, 2026
f5f1383
Merge branch 'main' into fix/gorm-respect-remove-integration-service-…
guipace Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contrib/gorm.io/gorm.v1/option.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func (fn OptionFn) apply(cfg *config) {

func newConfigWithDefaults() *config {
cfg := new(config)
cfg.serviceName = "gorm.db"
cfg.serviceName = instr.ServiceName(instrumentation.ComponentDefault, nil)
cfg.serviceSource = string(instrumentation.PackageGormIOGormV1)
cfg.analyticsRate = instr.AnalyticsRate(false)
cfg.errCheck = func(error) bool { return true }
Expand Down
6 changes: 6 additions & 0 deletions instrumentation/packages.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,6 +795,12 @@ var packages = map[Package]PackageInfo{
},
PackageGormIOGormV1: {
TracedPackage: "gorm.io/gorm",
naming: map[Component]componentNames{
ComponentDefault: {
useDDServiceV0: false,
buildServiceNameV0: staticName("gorm.db"),
},
},
Copy link
Copy Markdown
Contributor

@rarguelloF rarguelloF Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Could we add a test that reproduces the original bug to prevent regressions?

There is a specific test suite for the service names and these configurations in instrumentation/internal/namingschematest. You can add a new testcase in gorm_test.go and add it to the test suite in main_test.go.

Copy link
Copy Markdown
Contributor Author

@guipace guipace Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just saw this. Glad we're able to get a fix in place.

},
PackageGorillaMux: {
TracedPackage: "github.com/gorilla/mux",
Expand Down