feat(ci): govulncheck - add gVisor sandboxing via geomys/sandboxed-step #4598
+23
−15
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,8 +40,9 @@ permissions: | |
| jobs: | ||
| # Non-blocking: generates SARIF and uploads to GitHub Code Scanning. | ||
| # Replaces Dependabot Security Alerts with reachability-aware findings. | ||
| # govulncheck execution is sandboxed via geomys/sandboxed-step (gVisor) | ||
| # to strip ambient authority from the runner — see PR description for | ||
| # allowlist request context. | ||
| # NOTE: Only core packages are scanned here. Contrib modules (each with | ||
| # their own go.mod) are scanned in govulncheck-tests, which blocks merges, | ||
| # but contrib vulnerabilities do not appear in GitHub Code Scanning alerts. | ||
|
|
@@ -57,15 +58,18 @@ jobs: | |
| with: | ||
| go-version: stable | ||
| cache-dependency-path: '**/go.sum' | ||
| - name: Run govulncheck (SARIF, sandboxed) | ||
| # geomys/sandboxed-step uses gVisor to confine execution, preventing | ||
| # supply chain attacks from exfiltrating tokens or making network calls. | ||
| # -format sarif exits 0 even when vulnerabilities are found, so the | ||
| # upload step always runs. The blocking check is in govulncheck-tests. | ||
| uses: geomys/sandboxed-step@v1.2.1 | ||
| with: | ||
| run: |- | ||
| go install golang.org/x/vuln/cmd/govulncheck@latest | ||
| govulncheck -format sarif \ | ||
|
Comment on lines
+69
to
+70
There was a problem hiding this comment.
In this sandbox Useful? React with 👍 / 👎. |
||
| ./ddtrace/... ./appsec/... ./profiler/... ./internal/... ./instrumentation/... \ | ||
| > govulncheck.sarif || true | ||
| - name: Upload SARIF to GitHub Code Scanning | ||
| if: always() | ||
| uses: github/codeql-action/upload-sarif@38697555549f1db7851b81482ff19f1fa5c4fedc # v4.34.1 | ||
|
|
@@ -75,6 +79,7 @@ jobs: | |
|
|
||
| # Blocking: fails the build if any reachable vulnerability is found. | ||
| # Scans both core packages and all contrib modules (each with its own go.mod). | ||
| # govulncheck execution is sandboxed via geomys/sandboxed-step (gVisor). | ||
| govulncheck-tests: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
|
|
@@ -87,9 +92,12 @@ jobs: | |
| with: | ||
| go-version: stable | ||
| cache-dependency-path: '**/go.sum' | ||
| - name: Run govulncheck (sandboxed) | ||
| # geomys/sandboxed-step uses gVisor to confine execution, preventing | ||
| # supply chain attacks from exfiltrating tokens or making network calls. | ||
| uses: geomys/sandboxed-step@v1.2.1 | ||
| with: | ||
| run: | | ||
| go install golang.org/x/vuln/cmd/govulncheck@latest | ||
| govulncheck ./ddtrace/... ./appsec/... ./profiler/... ./internal/... ./instrumentation/... | ||
| ./.github/workflows/apps/govulncheck-contribs-v2.sh | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step writes
govulncheck.sarifinsidegeomys/sandboxed-step, but the followingupload-sarifstep runs back on the host and readsgovulncheck.sariffrom the workspace. The action documents that workspace changes do not persist by default and its default forpersist-workspace-changesisfalse(https://raw.githubusercontent.com/geomys/sandboxed-step/v1.2.1/README.md), so once the command succeeds the report is discarded with the sandbox overlay and Code Scanning has no SARIF file to upload; setpersist-workspace-changes: 'true'for this SARIF-producing step or copy the report out another way.Useful? React with 👍 / 👎.