Update instrumentation Gradle dependencies#11712
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
More details
All 438 changed files are Gradle lockfiles with no production code modifications — only test-classpath dependency versions bumped (re2j 1.7→1.8, Jackson 2.21→2.22, Armeria 1.39→1.40, Micrometer 1.16→1.17, Netty 4.2.13→4.2.15). No behavioral regression is possible from lockfile-only changes; any library-instrumentation incompatibility would surface as CI failures before merge.
🤖 Datadog Autotest · Commit 6a8e09f · What is Autotest? · Any feedback? Reach out in #autotest
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a8e09fdf7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -8,7 +8,7 @@ ch.qos.logback:logback-classic:1.1.11=compileClasspath,compileProtoPath,runtimeC | |||
| ch.qos.logback:logback-classic:1.2.13=testCompileClasspath,testCompileProtoPath,testRuntimeClasspath | |||
| ch.qos.logback:logback-core:1.1.11=compileClasspath,runtimeClasspath | |||
| ch.qos.logback:logback-core:1.2.13=testCompileClasspath,testCompileProtoPath,testRuntimeClasspath | |||
| ch.qos.logback:logback-core:1.5.34=compileProtoPath | |||
| ch.qos.logback:logback-core:1.5.35=compileProtoPath | |||
There was a problem hiding this comment.
Revert too-new logback-core lock
For dependency-update PRs, .github/workflows/update-gradle-dependencies.yaml enforces a 48h dependency-age cooldown, and this commit's generated summary says ch.qos.logback:logback-core:1.5.35 is still 42h short and should have been reverted. Leaving this lock entry advances the smoke test's compileProtoPath to the ineligible version despite the policy/revert summary, so please keep the previous 1.5.34 until it is eligible.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@sarahchen6 Please take a look, why logback was added to PR description report and to gradle.lockfile ?
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
alexey.kuznetsov@datadoghq.com unqueued this merge request |
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Kafka / producer-benchmarkParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 2 metrics, 0 unstable metrics.
See unchanged results
|
Kafka / consumer-benchmarkParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics. See unchanged results
|
|
/merge --cancel |
|
View all feedbacks in Devflow UI.
|
|
Closing this to test workflow following #11714 |
What Does This Do
This PR updates the Gradle dependency locks for instrumentations and their tests.
Motivation
Refresh Gradle dependencies to make sure to test latest versions of dependencies within their supported versions.
Dependency age policy
48h cooldown, reverted
Too new and no older eligible version exists, so the lockfiles were reverted to the baseline.
ch.qos.logback:logback-core:1.5.35is 42h away from meeting cooldownio.vertx:vertx-auth-common:5.1.3is 29h away from meeting cooldownio.vertx:vertx-bridge-common:5.1.3is 29h away from meeting cooldownio.vertx:vertx-core-logging:5.1.3is 29h away from meeting cooldownio.vertx:vertx-core:5.1.3is 29h away from meeting cooldownio.vertx:vertx-eventbus-bridge-common:5.1.3is 29h away from meeting cooldownio.vertx:vertx-uri-template:5.1.3is 29h away from meeting cooldownio.vertx:vertx-web-client:5.1.3is 29h away from meeting cooldownio.vertx:vertx-web-common:5.1.3is 29h away from meeting cooldownio.vertx:vertx-web:5.1.3is 29h away from meeting cooldownsoftware.amazon.awssdk:annotations:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:apache-client:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:apache5-client:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:arns:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:auth:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:aws-cbor-protocol:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:aws-core:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:aws-json-protocol:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:aws-query-protocol:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:aws-xml-protocol:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:checksums-spi:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:checksums:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:crt-core:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:dynamodb:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:endpoints-spi:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:eventbridge:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:http-auth-aws-eventstream:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:http-auth-aws:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:http-auth-spi:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:http-auth:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:http-client-spi:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:identity-spi:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:json-utils:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:kinesis:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:metrics-spi:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:netty-nio-client:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:profiles:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:protocol-core:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:regions:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:retries-spi:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:retries:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:s3:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:sdk-core:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:sfn:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:sns:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:third-party-jackson-core:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:third-party-jackson-dataformat-cbor:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:utils-lite:2.46.17is 37h away from meeting cooldownsoftware.amazon.awssdk:utils:2.46.17is 37h away from meeting cooldownContributor Checklist