feat: mark manually created spans with service source [APMLP-1016]#17006
feat: mark manually created spans with service source [APMLP-1016]#17006emmettbutler wants to merge 85 commits intomainfrom
Conversation
this will enable differentiation from services set via manual tracing
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 319705326d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Performance SLOsComparing candidate emmett.butler/manual-tracing-svc-src (20a1c08) with baseline main (97d4f14) 📈 Performance Regressions (2 suites)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 103.170µs (SLO: <130.000µs 📉 -20.6%) vs baseline: +3.4% Memory: ✅ 44.066MB (SLO: <46.000MB -4.2%) vs baseline: +5.0% ✅ add_inplace_aspectTime: ✅ 102.570µs (SLO: <130.000µs 📉 -21.1%) vs baseline: +0.9% Memory: ✅ 43.984MB (SLO: <46.000MB -4.4%) vs baseline: +4.8% ✅ add_inplace_noaspectTime: ✅ 28.354µs (SLO: <40.000µs 📉 -29.1%) vs baseline: ~same Memory: ✅ 43.903MB (SLO: <46.000MB -4.6%) vs baseline: +4.3% ✅ add_noaspectTime: ✅ 48.791µs (SLO: <70.000µs 📉 -30.3%) vs baseline: -0.3% Memory: ✅ 43.955MB (SLO: <46.000MB -4.4%) vs baseline: +4.5% ✅ bytearray_aspectTime: ✅ 253.225µs (SLO: <400.000µs 📉 -36.7%) vs baseline: ~same Memory: ✅ 43.840MB (SLO: <46.000MB -4.7%) vs baseline: +4.3% ✅ bytearray_extend_aspectTime: ✅ 650.305µs (SLO: <800.000µs 📉 -18.7%) vs baseline: -1.5% Memory: ✅ 43.890MB (SLO: <46.000MB -4.6%) vs baseline: +4.8% ✅ bytearray_extend_noaspectTime: ✅ 266.269µs (SLO: <400.000µs 📉 -33.4%) vs baseline: +1.1% Memory: ✅ 43.924MB (SLO: <46.000MB -4.5%) vs baseline: +4.4% ✅ bytearray_noaspectTime: ✅ 139.138µs (SLO: <300.000µs 📉 -53.6%) vs baseline: -0.2% Memory: ✅ 43.842MB (SLO: <46.000MB -4.7%) vs baseline: +4.1% ✅ bytes_aspectTime: ✅ 217.898µs (SLO: <300.000µs 📉 -27.4%) vs baseline: -1.1% Memory: ✅ 44.007MB (SLO: <46.000MB -4.3%) vs baseline: +5.0% ✅ bytes_noaspectTime: ✅ 134.133µs (SLO: <200.000µs 📉 -32.9%) vs baseline: +1.9% Memory: ✅ 44.088MB (SLO: <46.000MB -4.2%) vs baseline: +5.1% ✅ bytesio_aspectTime: ✅ 3.788ms (SLO: <5.000ms 📉 -24.2%) vs baseline: +0.4% Memory: ✅ 43.933MB (SLO: <46.000MB -4.5%) vs baseline: +4.5% ✅ bytesio_noaspectTime: ✅ 313.267µs (SLO: <420.000µs 📉 -25.4%) vs baseline: -0.4% Memory: ✅ 43.945MB (SLO: <46.000MB -4.5%) vs baseline: +4.7% ✅ capitalize_aspectTime: ✅ 88.173µs (SLO: <300.000µs 📉 -70.6%) vs baseline: +0.3% Memory: ✅ 43.988MB (SLO: <46.000MB -4.4%) vs baseline: +4.7% ✅ capitalize_noaspectTime: ✅ 245.718µs (SLO: <300.000µs 📉 -18.1%) vs baseline: -0.4% Memory: ✅ 43.929MB (SLO: <46.000MB -4.5%) vs baseline: +4.8% ✅ casefold_aspectTime: ✅ 91.223µs (SLO: <500.000µs 📉 -81.8%) vs baseline: +3.4% Memory: ✅ 44.043MB (SLO: <46.000MB -4.3%) vs baseline: +4.9% ✅ casefold_noaspectTime: ✅ 299.897µs (SLO: <500.000µs 📉 -40.0%) vs baseline: -1.5% Memory: ✅ 43.841MB (SLO: <46.000MB -4.7%) vs baseline: +4.8% ✅ decode_aspectTime: ✅ 86.721µs (SLO: <100.000µs 📉 -13.3%) vs baseline: -0.3% Memory: ✅ 43.876MB (SLO: <46.000MB -4.6%) vs baseline: +4.6% ✅ decode_noaspectTime: ✅ 152.333µs (SLO: <210.000µs 📉 -27.5%) vs baseline: +0.2% Memory: ✅ 44.075MB (SLO: <46.000MB -4.2%) vs baseline: +5.0% ✅ encode_aspectTime: ✅ 84.227µs (SLO: <200.000µs 📉 -57.9%) vs baseline: +0.4% Memory: ✅ 43.868MB (SLO: <46.000MB -4.6%) vs baseline: +4.6% ✅ encode_noaspectTime: ✅ 141.942µs (SLO: <200.000µs 📉 -29.0%) vs baseline: +1.9% Memory: ✅ 43.955MB (SLO: <46.000MB -4.4%) vs baseline: +5.1% ✅ format_aspectTime: ✅ 14.637ms (SLO: <19.200ms 📉 -23.8%) vs baseline: ~same Memory: ✅ 44.201MB (SLO: <46.000MB -3.9%) vs baseline: +4.9% ✅ format_map_aspectTime: ✅ 16.383ms (SLO: <21.500ms 📉 -23.8%) vs baseline: -0.2% Memory: ✅ 44.124MB (SLO: <46.000MB -4.1%) vs baseline: +4.5% ✅ format_map_noaspectTime: ✅ 372.484µs (SLO: <500.000µs 📉 -25.5%) vs baseline: -0.3% Memory: ✅ 43.929MB (SLO: <46.000MB -4.5%) vs baseline: +4.9% ✅ format_noaspectTime: ✅ 302.690µs (SLO: <500.000µs 📉 -39.5%) vs baseline: -0.3% Memory: ✅ 43.897MB (SLO: <46.000MB -4.6%) vs baseline: +4.7% ✅ index_aspectTime: ✅ 123.444µs (SLO: <300.000µs 📉 -58.9%) vs baseline: +0.2% Memory: ✅ 43.927MB (SLO: <46.000MB -4.5%) vs baseline: +4.6% ✅ index_noaspectTime: ✅ 40.502µs (SLO: <300.000µs 📉 -86.5%) vs baseline: -0.3% Memory: ✅ 43.951MB (SLO: <46.000MB -4.5%) vs baseline: +4.6% ✅ join_aspectTime: ✅ 209.182µs (SLO: <300.000µs 📉 -30.3%) vs baseline: ~same Memory: ✅ 43.931MB (SLO: <46.000MB -4.5%) vs baseline: +4.5% ✅ join_noaspectTime: ✅ 143.739µs (SLO: <300.000µs 📉 -52.1%) vs baseline: +0.1% Memory: ✅ 43.912MB (SLO: <46.000MB -4.5%) vs baseline: +4.7% ✅ ljust_aspectTime: ✅ 496.645µs (SLO: <700.000µs 📉 -29.1%) vs baseline: -1.0% Memory: ✅ 43.771MB (SLO: <46.000MB -4.8%) vs baseline: +4.0% ✅ ljust_noaspectTime: ✅ 257.498µs (SLO: <300.000µs 📉 -14.2%) vs baseline: +0.9% Memory: ✅ 43.981MB (SLO: <46.000MB -4.4%) vs baseline: +4.8% ✅ lower_aspectTime: ✅ 293.486µs (SLO: <500.000µs 📉 -41.3%) vs baseline: -1.2% Memory: ✅ 43.960MB (SLO: <46.000MB -4.4%) vs baseline: +4.7% ✅ lower_noaspectTime: ✅ 231.900µs (SLO: <300.000µs 📉 -22.7%) vs baseline: -0.3% Memory: ✅ 43.958MB (SLO: <46.000MB -4.4%) vs baseline: +4.4% ✅ lstrip_aspectTime: ✅ 0.335ms (SLO: <3.000ms 📉 -88.8%) vs baseline: 📈 +22.0% Memory: ✅ 43.972MB (SLO: <46.000MB -4.4%) vs baseline: +5.0% ✅ lstrip_noaspectTime: ✅ 0.177ms (SLO: <3.000ms 📉 -94.1%) vs baseline: +1.5% Memory: ✅ 43.972MB (SLO: <46.000MB -4.4%) vs baseline: +4.9% ✅ modulo_aspectTime: ✅ 14.294ms (SLO: <18.750ms 📉 -23.8%) vs baseline: ~same Memory: ✅ 44.112MB (SLO: <46.000MB -4.1%) vs baseline: +5.0% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 14.839ms (SLO: <19.350ms 📉 -23.3%) vs baseline: ~same Memory: ✅ 44.171MB (SLO: <46.000MB -4.0%) vs baseline: +4.9% ✅ modulo_aspect_for_bytesTime: ✅ 14.395ms (SLO: <18.900ms 📉 -23.8%) vs baseline: -0.2% Memory: ✅ 43.942MB (SLO: <46.000MB -4.5%) vs baseline: +4.3% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 14.576ms (SLO: <19.150ms 📉 -23.9%) vs baseline: -0.4% Memory: ✅ 44.084MB (SLO: <46.000MB -4.2%) vs baseline: +4.6% ✅ modulo_noaspectTime: ✅ 0.353ms (SLO: <3.000ms 📉 -88.2%) vs baseline: -1.0% Memory: ✅ 43.906MB (SLO: <46.000MB -4.6%) vs baseline: +4.4% ✅ replace_aspectTime: ✅ 18.474ms (SLO: <24.000ms 📉 -23.0%) vs baseline: +0.3% Memory: ✅ 44.209MB (SLO: <46.000MB -3.9%) vs baseline: +4.9% ✅ replace_noaspectTime: ✅ 295.670µs (SLO: <400.000µs 📉 -26.1%) vs baseline: +5.3% Memory: ✅ 43.802MB (SLO: <46.000MB -4.8%) vs baseline: +4.4% ✅ repr_aspectTime: ✅ 319.468µs (SLO: <420.000µs 📉 -23.9%) vs baseline: -0.5% Memory: ✅ 43.928MB (SLO: <46.000MB -4.5%) vs baseline: +4.6% ✅ repr_noaspectTime: ✅ 46.614µs (SLO: <90.000µs 📉 -48.2%) vs baseline: -0.7% Memory: ✅ 43.993MB (SLO: <46.000MB -4.4%) vs baseline: +4.7% ✅ rstrip_aspectTime: ✅ 383.723µs (SLO: <500.000µs 📉 -23.3%) vs baseline: -0.5% Memory: ✅ 43.939MB (SLO: <46.000MB -4.5%) vs baseline: +4.4% ✅ rstrip_noaspectTime: ✅ 181.224µs (SLO: <300.000µs 📉 -39.6%) vs baseline: -0.2% Memory: ✅ 44.077MB (SLO: <46.000MB -4.2%) vs baseline: +5.1% ✅ slice_aspectTime: ✅ 184.653µs (SLO: <300.000µs 📉 -38.4%) vs baseline: -0.2% Memory: ✅ 43.897MB (SLO: <46.000MB -4.6%) vs baseline: +4.5% ✅ slice_noaspectTime: ✅ 54.358µs (SLO: <90.000µs 📉 -39.6%) vs baseline: -1.5% Memory: ✅ 44.059MB (SLO: <46.000MB -4.2%) vs baseline: +5.0% ✅ stringio_aspectTime: ✅ 3.805ms (SLO: <5.000ms 📉 -23.9%) vs baseline: ~same Memory: ✅ 43.906MB (SLO: <46.000MB -4.6%) vs baseline: +4.8% ✅ stringio_noaspectTime: ✅ 344.184µs (SLO: <500.000µs 📉 -31.2%) vs baseline: ~same Memory: ✅ 43.880MB (SLO: <46.000MB -4.6%) vs baseline: +4.4% ✅ strip_aspectTime: ✅ 276.160µs (SLO: <350.000µs 📉 -21.1%) vs baseline: ~same Memory: ✅ 44.069MB (SLO: <46.000MB -4.2%) vs baseline: +4.9% ✅ strip_noaspectTime: ✅ 175.705µs (SLO: <240.000µs 📉 -26.8%) vs baseline: +1.0% Memory: ✅ 43.993MB (SLO: <46.000MB -4.4%) vs baseline: +4.7% ✅ swapcase_aspectTime: ✅ 335.268µs (SLO: <500.000µs 📉 -32.9%) vs baseline: +1.7% Memory: ✅ 43.947MB (SLO: <46.000MB -4.5%) vs baseline: +4.8% ✅ swapcase_noaspectTime: ✅ 266.565µs (SLO: <400.000µs 📉 -33.4%) vs baseline: -1.0% Memory: ✅ 43.908MB (SLO: <46.000MB -4.5%) vs baseline: +4.6% ✅ title_aspectTime: ✅ 321.045µs (SLO: <500.000µs 📉 -35.8%) vs baseline: +0.5% Memory: ✅ 43.974MB (SLO: <46.000MB -4.4%) vs baseline: +4.5% ✅ title_noaspectTime: ✅ 257.456µs (SLO: <400.000µs 📉 -35.6%) vs baseline: +0.5% Memory: ✅ 44.004MB (SLO: <46.000MB -4.3%) vs baseline: +5.0% ✅ translate_aspectTime: ✅ 537.109µs (SLO: <700.000µs 📉 -23.3%) vs baseline: +9.5% Memory: ✅ 43.959MB (SLO: <46.000MB -4.4%) vs baseline: +5.0% ✅ translate_noaspectTime: ✅ 423.119µs (SLO: <500.000µs 📉 -15.4%) vs baseline: -1.4% Memory: ✅ 43.979MB (SLO: <46.000MB -4.4%) vs baseline: +4.8% ✅ upper_aspectTime: ✅ 297.298µs (SLO: <500.000µs 📉 -40.5%) vs baseline: +1.0% Memory: ✅ 43.900MB (SLO: <46.000MB -4.6%) vs baseline: +4.9% ✅ upper_noaspectTime: ✅ 231.900µs (SLO: <400.000µs 📉 -42.0%) vs baseline: -0.8% Memory: ✅ 43.957MB (SLO: <46.000MB -4.4%) vs baseline: +4.7% 📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 513.036µs (SLO: <700.000µs 📉 -26.7%) vs baseline: 📈 +22.1% Memory: ✅ 43.837MB (SLO: <46.000MB -4.7%) vs baseline: +5.1% ✅ ospathbasename_noaspectTime: ✅ 431.373µs (SLO: <700.000µs 📉 -38.4%) vs baseline: +0.2% Memory: ✅ 43.925MB (SLO: <46.000MB -4.5%) vs baseline: +4.9% ✅ ospathjoin_aspectTime: ✅ 625.360µs (SLO: <700.000µs 📉 -10.7%) vs baseline: ~same Memory: ✅ 43.865MB (SLO: <46.000MB -4.6%) vs baseline: +5.0% ✅ ospathjoin_noaspectTime: ✅ 631.241µs (SLO: <700.000µs -9.8%) vs baseline: +0.4% Memory: ✅ 43.831MB (SLO: <46.000MB -4.7%) vs baseline: +4.8% ✅ ospathnormcase_aspectTime: ✅ 349.904µs (SLO: <700.000µs 📉 -50.0%) vs baseline: -0.2% Memory: ✅ 43.894MB (SLO: <46.000MB -4.6%) vs baseline: +4.9% ✅ ospathnormcase_noaspectTime: ✅ 358.305µs (SLO: <700.000µs 📉 -48.8%) vs baseline: +0.2% Memory: ✅ 43.855MB (SLO: <46.000MB -4.7%) vs baseline: +5.1% ✅ ospathsplit_aspectTime: ✅ 486.316µs (SLO: <700.000µs 📉 -30.5%) vs baseline: +0.7% Memory: ✅ 43.806MB (SLO: <46.000MB -4.8%) vs baseline: +4.9% ✅ ospathsplit_noaspectTime: ✅ 494.050µs (SLO: <700.000µs 📉 -29.4%) vs baseline: ~same Memory: ✅ 43.831MB (SLO: <46.000MB -4.7%) vs baseline: +5.0% ✅ ospathsplitdrive_aspectTime: ✅ 371.532µs (SLO: <700.000µs 📉 -46.9%) vs baseline: -0.2% Memory: ✅ 43.815MB (SLO: <46.000MB -4.8%) vs baseline: +4.9% ✅ ospathsplitdrive_noaspectTime: ✅ 72.899µs (SLO: <700.000µs 📉 -89.6%) vs baseline: +0.6% Memory: ✅ 43.933MB (SLO: <46.000MB -4.5%) vs baseline: +4.9% ✅ ospathsplitext_aspectTime: ✅ 451.426µs (SLO: <700.000µs 📉 -35.5%) vs baseline: -1.4% Memory: ✅ 43.838MB (SLO: <46.000MB -4.7%) vs baseline: +5.0% ✅ ospathsplitext_noaspectTime: ✅ 463.679µs (SLO: <700.000µs 📉 -33.8%) vs baseline: -0.4% Memory: ✅ 43.798MB (SLO: <46.000MB -4.8%) vs baseline: +4.8% 🟡 Near SLO Breach (4 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 19.798ms (SLO: <22.300ms 📉 -11.2%) vs baseline: -0.1% Memory: ✅ 69.358MB (SLO: <73.500MB -5.6%) vs baseline: +4.9% ✅ exception-replay-enabledTime: ✅ 1.352ms (SLO: <1.450ms -6.8%) vs baseline: ~same Memory: ✅ 67.524MB (SLO: <71.500MB -5.6%) vs baseline: +4.9% ✅ iastTime: ✅ 19.848ms (SLO: <22.250ms 📉 -10.8%) vs baseline: -0.6% Memory: ✅ 69.358MB (SLO: <75.000MB -7.5%) vs baseline: +4.8% ✅ profilerTime: ✅ 15.073ms (SLO: <16.550ms -8.9%) vs baseline: -0.2% Memory: ✅ 60.470MB (SLO: <61.000MB 🟡 -0.9%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 19.713ms (SLO: <21.750ms -9.4%) vs baseline: -0.1% Memory: ✅ 69.342MB (SLO: <73.500MB -5.7%) vs baseline: +5.0% ✅ span-code-originTime: ✅ 20.397ms (SLO: <28.200ms 📉 -27.7%) vs baseline: +1.7% Memory: ✅ 69.527MB (SLO: <75.000MB -7.3%) vs baseline: +5.1% ✅ tracerTime: ✅ 19.757ms (SLO: <21.750ms -9.2%) vs baseline: -0.6% Memory: ✅ 69.282MB (SLO: <75.000MB -7.6%) vs baseline: +4.9% ✅ tracer-and-profilerTime: ✅ 21.221ms (SLO: <23.500ms -9.7%) vs baseline: +0.1% Memory: ✅ 71.397MB (SLO: <75.000MB -4.8%) vs baseline: +5.1% ✅ tracer-dont-create-db-spansTime: ✅ 19.931ms (SLO: <21.500ms -7.3%) vs baseline: -0.2% Memory: ✅ 69.360MB (SLO: <75.000MB -7.5%) vs baseline: +4.9% ✅ tracer-minimalTime: ✅ 16.932ms (SLO: <17.500ms -3.2%) vs baseline: +0.2% Memory: ✅ 69.357MB (SLO: <75.000MB -7.5%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 19.720ms (SLO: <21.750ms -9.3%) vs baseline: -0.2% Memory: ✅ 69.291MB (SLO: <72.500MB -4.4%) vs baseline: +4.9% ✅ tracer-no-cachesTime: ✅ 17.739ms (SLO: <19.650ms -9.7%) vs baseline: -0.2% Memory: ✅ 69.373MB (SLO: <75.000MB -7.5%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 19.451ms (SLO: <20.100ms -3.2%) vs baseline: -0.2% Memory: ✅ 69.357MB (SLO: <75.000MB -7.5%) vs baseline: +4.9% ✅ tracer-no-middlewareTime: ✅ 19.548ms (SLO: <21.500ms -9.1%) vs baseline: ~same Memory: ✅ 69.307MB (SLO: <75.000MB -7.6%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 19.809ms (SLO: <22.000ms -10.0%) vs baseline: +0.7% Memory: ✅ 69.419MB (SLO: <73.500MB -5.6%) vs baseline: +5.0% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 3.392ms (SLO: <4.750ms 📉 -28.6%) vs baseline: ~same Memory: ✅ 56.595MB (SLO: <66.500MB 📉 -14.9%) vs baseline: +5.0% ✅ appsec-postTime: ✅ 2.885ms (SLO: <6.750ms 📉 -57.3%) vs baseline: +0.2% Memory: ✅ 56.590MB (SLO: <66.500MB 📉 -14.9%) vs baseline: +4.8% ✅ appsec-telemetryTime: ✅ 3.409ms (SLO: <4.750ms 📉 -28.2%) vs baseline: +1.0% Memory: ✅ 56.571MB (SLO: <66.500MB 📉 -14.9%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.880ms (SLO: <2.000ms -6.0%) vs baseline: ~same Memory: ✅ 49.199MB (SLO: <51.500MB -4.5%) vs baseline: +4.9% ✅ iast-getTime: ✅ 1.873ms (SLO: <2.000ms -6.3%) vs baseline: -0.1% Memory: ✅ 46.037MB (SLO: <49.000MB -6.0%) vs baseline: +5.1% ✅ profilerTime: ✅ 1.908ms (SLO: <2.100ms -9.2%) vs baseline: -0.2% Memory: ✅ 52.583MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 3.365ms (SLO: <3.650ms -7.8%) vs baseline: -0.3% Memory: ✅ 56.538MB (SLO: <60.000MB -5.8%) vs baseline: +4.8% ✅ tracerTime: ✅ 3.375ms (SLO: <3.650ms -7.5%) vs baseline: ~same Memory: ✅ 56.493MB (SLO: <60.000MB -5.8%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 3.377ms (SLO: <3.650ms -7.5%) vs baseline: ~same Memory: ✅ 56.570MB (SLO: <60.000MB -5.7%) vs baseline: +5.0% 🟡 recursivecomputation - 8/8✅ deepTime: ✅ 311.596ms (SLO: <320.950ms -2.9%) vs baseline: -0.1% Memory: ✅ 37.532MB (SLO: <38.750MB -3.1%) vs baseline: +5.2% ✅ deep-profiledTime: ✅ 330.223ms (SLO: <359.150ms -8.1%) vs baseline: ~same Memory: ✅ 43.844MB (SLO: <46.000MB -4.7%) vs baseline: +5.0% ✅ mediumTime: ✅ 7.342ms (SLO: <7.400ms 🟡 -0.8%) vs baseline: -0.2% Memory: ✅ 36.687MB (SLO: <38.000MB -3.5%) vs baseline: +5.0% ✅ shallowTime: ✅ 1.025ms (SLO: <1.050ms -2.4%) vs baseline: +1.3% Memory: ✅ 36.746MB (SLO: <38.000MB -3.3%) vs baseline: +5.0% 🟡 tracer - 6/6✅ largeTime: ✅ 32.183ms (SLO: <32.950ms -2.3%) vs baseline: ~same Memory: ✅ 37.749MB (SLO: <39.250MB -3.8%) vs baseline: +5.0% ✅ mediumTime: ✅ 3.230ms (SLO: <3.200ms +0.9%) vs baseline: +1.9% Memory: ✅ 36.176MB (SLO: <38.750MB -6.6%) vs baseline: +4.2% ✅ smallTime: ✅ 367.021µs (SLO: <370.000µs 🟡 -0.8%) vs baseline: +3.1% Memory: ✅ 36.313MB (SLO: <38.750MB -6.3%) vs baseline: +4.9%
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 20a1c08 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Codeowners resolved as |
avoid attempting to delete nonexistent key
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 62d1794cce
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b15a942fc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| service_source = parent.get_tag(_SERVICE_SOURCE) or "" | ||
| else: | ||
| service = config.service | ||
| service = service_source = config.service |
There was a problem hiding this comment.
_dd.svc_src
When no explicit service is provided and there is no parent, this assigns service_source to config.service, so _dd.svc_src is later emitted as the literal service name (for example web-api) instead of a source token. This affects root spans started without an explicit service whenever DD_SERVICE/config.service is set, and it will break downstream logic that expects _dd.svc_src to contain controlled source values (such as manual or option markers).
Useful? React with 👍 / 👎.
| service=trace_utils.ext_service(pin, config), | ||
| span_type=conf.get("span_type"), | ||
| ) as span: | ||
| set_service_and_source(span, trace_utils.ext_service(pin, config), config.vertica) |
There was a problem hiding this comment.
Inside _install_routine, the config variable is already the Vertica IntegrationConfig passed from patch(), but this call dereferences config.vertica. IntegrationConfig does not expose a vertica attribute, so traced Vertica operations will raise AttributeError at runtime before executing the wrapped call. This breaks instrumented Vertica query paths entirely.
Useful? React with 👍 / 👎.
3 participants
This pull request implements the manual instrumentation requirement of the RFC referenced in APMLP-1016, tagging spans with
_dd.svc_src: mif and only if they were created via manual instrumentation. To enable this, the pull request also updates all integrations that set service names to avoid using the code paths that manual instrumentation uses to set service names. Snapshot tests affected by the new tags are changed to ignore the tags, and will be updated in future pull requests.