Skip to content

ci: delete lock files when they exist#17155

Open
KowalskiThomas wants to merge 1 commit intomainfrom
kowalski/ci-delete-lock-files-when-they-exist
Open

ci: delete lock files when they exist#17155
KowalskiThomas wants to merge 1 commit intomainfrom
kowalski/ci-delete-lock-files-when-they-exist

Conversation

@KowalskiThomas
Copy link
Copy Markdown
Contributor

@KowalskiThomas KowalskiThomas commented Mar 27, 2026 •
edited
Loading

No description provided.

@KowalskiThomas KowalskiThomas force-pushed the kowalski/ci-delete-lock-files-when-they-exist branch from 93fe4db to 272dd25 Compare March 27, 2026 08:07
@KowalskiThomas KowalskiThomas added the changelog/no-changelog A changelog entry is not required for this PR. label Mar 27, 2026
@KowalskiThomas KowalskiThomas marked this pull request as ready for review March 27, 2026 13:43
@KowalskiThomas KowalskiThomas requested review from a team as code owners March 27, 2026 13:43
@KowalskiThomas
Copy link
Copy Markdown
Contributor Author

KowalskiThomas commented Mar 27, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Mar 27, 2026 •
edited
Loading

View all feedbacks in Devflow UI.

2026-03-27 13:43:46 UTC ℹ️ Start processing command /merge

2026-03-27 13:43:52 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-03-27 14:08:58 UTC ⚠️ MergeQueue: This merge request was unqueued

thomas.kowalski@datadoghq.com unqueued this merge request

chatgpt-codex-connector[bot]
chatgpt-codex-connector bot reviewed Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 272dd2516f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

.gitlab/multi-os-tests.yml
os tests windows:
extends: .multi_os_test_base
tags: ["windows-v2:2022"]
pre_get_sources_script:
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Nest pre_get_sources_script under hooks

pre_get_sources_script is defined as a subkey of hooks in GitLab CI (hooks: pre_get_sources_script:), not as a top-level job key. With the current shape, this job config is invalid/ignored by GitLab, so the lockfile cleanup won’t run before checkout (and the same pattern is repeated in .gitlab/package.yml). This defeats the fix for stale .git/*.lock files on Windows runners.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

@taegyunkim taegyunkim Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KowalskiThomas please address this comment

Copy link
Copy Markdown
Contributor Author

@KowalskiThomas KowalskiThomas Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I removed the PR from the MQ because of this -- I'll take care of it when I get a chance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taegyunkim taegyunkim taegyunkim approved these changes

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments

@gnufede gnufede gnufede approved these changes

@brettlangdon brettlangdon brettlangdon approved these changes

@emmettbutler emmettbutler Awaiting requested review from emmettbutler emmettbutler is a code owner automatically assigned from DataDog/apm-core-python

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KowalskiThomas @gnufede @brettlangdon @taegyunkim