test(profiling): relax wall time assertions in test_accuracy_stack#17185
Open
KowalskiThomas wants to merge 1 commit intomainfrom
Open
test(profiling): relax wall time assertions in test_accuracy_stack#17185KowalskiThomas wants to merge 1 commit intomainfrom
test_accuracy_stack#17185KowalskiThomas wants to merge 1 commit intomainfrom
Conversation
|
I can only run on private repositories. |
KowalskiThomas
added
changelog/no-changelog
Codeowners resolved as |
KowalskiThomas
force-pushed
the
dd/kowalski/relax-cpu-wall-time-assertions
branch
from
1f56598 to
f823fd4
Compare
KowalskiThomas
changed the title
test_accuracy_stack
This comment has been minimized.
This comment has been minimized.
Co-authored-by: KowalskiThomas <14239160+KowalskiThomas@users.noreply.github.com>
KowalskiThomas
force-pushed
the
dd/kowalski/relax-cpu-wall-time-assertions
branch
from
f823fd4 to
94ca9f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes
test_accuracy_stackby relaxing the accuracy constraint on wall time (from 10% margin to 30%). Whereas CPU time is almost guaranteed (computed by taking Thread clock's elapsed time), wall time is not as OS scheduling can play a role in making certain Threads take longer to execute a certain amount of CPU time than expected. (I have a feeling this is worse in CI, as I can't reproduce locally...)On the other hand, I also changed the test so we make sure the wall time is never less than what we expect -- this should never happen and would show a correctness problem.