-
Notifications
You must be signed in to change notification settings - Fork 493
perf: use serverless-specific wheel in layer #17201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
emmettbutler
wants to merge
15
commits into
main
Choose a base branch
from
emmett.butler/serverless-wheels
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+57
−35
Draft
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
03405c6
use serverless-specific wheel in layer
emmettbutler c3e21ba
validate serverless wheels
emmettbutler 1f834ad
dont rm
emmettbutler acd9d6a
depend on build linux serverless
emmettbutler 42d0a13
Merge branch 'main' into emmett.butler/serverless-wheels
emmettbutler e1d47dd
separate jobs to avoid size limit
emmettbutler c95a8d5
debug output
emmettbutler 40d9399
underscore issue
emmettbutler 19f665c
another hyphen thing
emmettbutler ac29319
ugh
emmettbutler d3903df
only serverless, for testing
emmettbutler de4be0d
lint
emmettbutler a52ee16
make a serverless validation mode
emmettbutler 3fb712c
lint
emmettbutler b667d1e
missing variable
emmettbutler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the downstream trigger branch from
maintoemmett.butler/serverless-wheelsmakes this job validate against a personal feature ref instead of the canonical datadog-lambda-python line, so compatibility regressions on upstreammaincan slip through unnoticed; if that branch is renamed/deleted, thisallow_failurejob will silently stop providing useful signal. For release confidence, this trigger should stay on a stable shared branch (or be parameterized explicitly for temporary experiments).Useful? React with 👍 / 👎.