Skip to content

Conversation

@cbeauchesne
Copy link
Contributor

What does this PR do?

Motivation:

Change log entry

Additional Notes:

How to test the change?

@cbeauchesne cbeauchesne requested review from a team as code owners January 20, 2026 10:13
@cbeauchesne cbeauchesne requested a review from vpellan January 20, 2026 10:13
@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label Jan 20, 2026
@github-actions
Copy link

👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2026-01-20 10:13:20 UTC

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 20, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
Patch Coverage: 100.00%
Overall Coverage: 95.19%

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 929a272 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Jan 20, 2026

Benchmarks

Benchmark execution time: 2026-01-20 14:19:50

Comparing candidate commit 929a272 in PR branch cbeauchesne/try-fix-test-name with baseline commit 43c3da4 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics.

scenario:tracing - Tracing.log_correlation

  • 🟥 throughput [-11152.652op/s; -10872.666op/s] or [-10.166%; -9.911%]

@p-datadog p-datadog marked this pull request as draft January 20, 2026 12:56
Comment on lines +11 to +12
stub_const(
'TestIntegrationClass',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is a heavy-handed way to have the class's name method return TestIntegrationClass or something.

Is anything even referencing the constant TestIntegrationClass anywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is anything even referencing the constant TestIntegrationClass anywhere?

No, it's only a test to see if it fixes the issue. I'll definitly need your help to arrange this in a way that fit ruby idioms.

Comment on lines +17 to +19
def inspect
'TestIntegrationClass'
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of the ways to remove the standard #<Class:0x12345> stringification of dynamic classes.

There's also to_s that might end up being used, and self.name. Maybe self.to_s and self.inspect as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which one you think is the best fit ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can define classes the old-fashioned way: https://github.com/DataDog/dd-trace-rb/blob/master/spec/datadog/di/serializer_spec.rb#L5

But, I don't know what you are attempting to achieve with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev/testing Involves testing processes (e.g. RSpec)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants