-
Notifications
You must be signed in to change notification settings - Fork 399
[wip] try to fix test names #5259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description. If changes need to be present in CHANGELOG.md you can state it this way **Change log entry**
Yes. A brief summary to be placed into the CHANGELOG.md(possible answers Yes/Yep/Yeah) Or you can opt out like that **Change log entry**
None.(possible answers No/Nope/None) Visited at: 2026-01-20 10:13:20 UTC |
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 929a272 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksBenchmark execution time: 2026-01-20 14:19:50 Comparing candidate commit 929a272 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 43 metrics, 2 unstable metrics. scenario:tracing - Tracing.log_correlation
|
| stub_const( | ||
| 'TestIntegrationClass', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is a heavy-handed way to have the class's name method return TestIntegrationClass or something.
Is anything even referencing the constant TestIntegrationClass anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is anything even referencing the constant TestIntegrationClass anywhere?
No, it's only a test to see if it fixes the issue. I'll definitly need your help to arrange this in a way that fit ruby idioms.
| def inspect | ||
| 'TestIntegrationClass' | ||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one of the ways to remove the standard #<Class:0x12345> stringification of dynamic classes.
There's also to_s that might end up being used, and self.name. Maybe self.to_s and self.inspect as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which one you think is the best fit ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can define classes the old-fashioned way: https://github.com/DataDog/dd-trace-rb/blob/master/spec/datadog/di/serializer_spec.rb#L5
But, I don't know what you are attempting to achieve with this PR.
What does this PR do?
Motivation:
Change log entry
Additional Notes:
How to test the change?