fix: remove incorrect escaping from $basearch in the Datadog Security CLI repository URL #38130
Open
nikhilvarpe wants to merge 2 commits into
Open
fix: remove incorrect escaping from $basearch in the Datadog Security CLI repository URL #38130nikhilvarpe wants to merge 2 commits into
nikhilvarpe wants to merge 2 commits into
Conversation
… CLI repository URL Remove the unnecessary escape character before the $basearch variable in the Datadog Security CLI YUM repository URL. The escaped value (\$basearch) caused YUM/DNF to construct an invalid repository path, resulting in a 404 error while fetching repository metadata. Using $basearch directly allows YUM/DNF to correctly resolve the system architecture (e.g., x86_64) and access the appropriate package repository. This change restores successful repository metadata retrieval and enables the Datadog Security CLI package to be installed correctly on supported RPM-based systems.
Contributor
|
Hi @nikhilvarpe, thanks for opening this PR! We'll review and be back in touch. |
maycmlee
added
the
under_review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the unnecessary escape character before the $basearch variable in the Datadog Security CLI YUM repository URL for Red Hat/CentOS.
The escaped value ($basearch) caused YUM/DNF to generate an invalid repository path, resulting in a 404 error while fetching repository metadata. Using $basearch directly allows YUM/DNF to correctly resolve the system architecture (for example, x86_64) and access the appropriate package repository.
This change ensures that the Datadog Security CLI can be installed successfully using the package repository instructions for Red Hat/CentOS and other supported RPM-based systems.
The attached file consist of code snippet of the tested code : security-cli-code-snippet.txt