Use in GitHub jobs the Docker image built by GitLab CI#47
Open
xlamorlette-datadog wants to merge 3 commits intomainfrom
Open
Use in GitHub jobs the Docker image built by GitLab CI#47xlamorlette-datadog wants to merge 3 commits intomainfrom
xlamorlette-datadog wants to merge 3 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
=======================================
Coverage 63.12% 63.12%
=======================================
Files 7 7
Lines 377 377
Branches 49 49
=======================================
Hits 238 238
Misses 101 101
Partials 38 38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xlamorlette-datadog
force-pushed
the
xlamorlette/rationalize-ci-docker-image
branch
2 times, most recently
from
b00eef9 to
0854985
Compare
…uild-ci-image GitLab job.
xlamorlette-datadog
force-pushed
the
xlamorlette/rationalize-ci-docker-image
branch
from
0854985 to
63d695d
Compare
xlamorlette-datadog
changed the title
xlamorlette-datadog
requested review from
Anilm3
and removed request for
a team
| group: ${{ (github.event_name == 'pull_request' && format('{0}-{1}', github.workflow, github.ref)) || format('{0}-{1}', github.workflow, github.run_id) }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
Could we isolate the hash value to a variable and then use that when composing the image below?
Suggested change
| env: | |
| ci_image_hash: 28219c0ef3e00f1e3d5afcab61a73a5e9bd2a9b957d7545556711cce2a6262cd | |
| jobs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the time of writing, the Docker image used for GitHub CI jobs cannot be built anymore:
It should be done with
make push-ci-images.But this fails because the base image
public.ecr.aws/b1o7r7e0/nginx_musl_toolchain:latestis no more available.To fix this, let's rather use the Docker image built by the GitLab CI.
This is documented in the different GitHub jobs configuration files and in the
Makefile. I also documented how to update this CI image in the CI (Apache Module) Confluence page.By the way, I also added in this Docker image the
nodejs npmpackages needed for uploading code coverage to Datadog.We can see that this works fine in a successful job run: