Skip to content

fix: emit context attributes regardless of active span #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jbachorik wants to merge 3 commits into from
Closed

fix: emit context attributes regardless of active span #575

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
179048d
fix: emit context attributes regardless of active span
jbachorik Jun 3, 2026
2454eeb
Merge branch 'main' into jb/fix-writeCurrentContext-span-gate
jbachorik Jun 8, 2026
891ce39
fix: restore hasContext gate on sidecar reads in writeCurrentContext
jbachorik Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ddprof-lib/src/main/cpp/flightRecorder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1699,9 +1699,11 @@ void Recording::writeContextSnapshot(Buffer *buf, Context &context) {
void Recording::writeCurrentContext(Buffer *buf) {
u64 spanId = 0;
u64 rootSpanId = 0;
bool hasContext = ContextApi::get(spanId, rootSpanId);
// spanId/rootSpanId are initialized to 0 above; ContextApi::get() only updates them
// on success, so 0s are always written when there is no valid context.
// on success, so 0s are always written when there is no active span.
// hasContext gates sidecar reads: getOtelTagEncoding() must only be called
// when valid=1 (see thread.h read invariant).
bool hasContext = ContextApi::get(spanId, rootSpanId);
buf->putVar64(spanId);
buf->putVar64(rootSpanId);

Expand Down
Loading