Open
Conversation
scottopell
force-pushed
the
feat/bean-listener
branch
from
c6c4270 to
75d9296
Compare
scottopell
commented
Apr 17, 2023
scottopell
commented
Apr 17, 2023
Collaborator
Author
|
carlosroman
reviewed
Jun 5, 2023
| return; | ||
| } | ||
| MBeanServerNotification mbs = (MBeanServerNotification) notification; | ||
| queue.offer(mbs); |
Contributor
There was a problem hiding this comment.
Do we want to do anything here if we get false back? Maybe log/warn we couldn't add the MBeanServerNotification?
# Conflicts: # tools/misbehaving-jmx-server/README.md
scottopell
force-pushed
the
feat/bean-listener
branch
from
b93caeb to
79ce047
Compare
…ReconnectContainer
# Conflicts: # src/main/java/org/datadog/jmxfetch/Instance.java # src/main/java/org/datadog/jmxfetch/JmxAttribute.java # src/test/java/org/datadog/jmxfetch/TestCommon.java
Co-authored-by: Kaylyn <kaylyn.sigler@datadoghq.com>
# Conflicts: # src/main/java/org/datadog/jmxfetch/App.java
…tion-level config
# Conflicts: # src/test/java/org/datadog/jmxfetch/TestCommon.java
# Conflicts: # src/main/java/org/datadog/jmxfetch/App.java # src/main/java/org/datadog/jmxfetch/Instance.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eCurrently there is a periodic refresh of the beans (and their attributes) which can result in CPU spikes as these remote RMI calls are expensive.
This PR implements a "subscription mode" for instances where a
javax.management.NotificationListeneris used to subscribe to bean registration/unregistration events.This approach should spread out the expensive RMI calls over time and will reduce the total amount of calls needed.
Status @ Feb 8 2024:
This branch is showing flakey tests, so they need to be investigated before this can be merged.
Once this branch is clean, I intend to merge this and publish a SNAPSHOT build which can be used in nightly agent builds to get validation. This agent branch is required before the snapshot/nightly.
Latest flakey report:
Ran 2000 times, 4 failures found