Skip to content

generate UDP on outside interfaces #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
secmff wants to merge 1 commit into
base: main
Choose a base branch
from
Open

generate UDP on outside interfaces #1722

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lading/src/generator/udp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ impl UdpWorker {
let total_bytes = self.block_cache.peek_next_size(&handle);

tokio::select! {
conn = UdpSocket::bind("127.0.0.1:0"), if connection.is_none() => {
conn = UdpSocket::bind("0.0.0.0:0"), if connection.is_none() => {
Copy link
Collaborator

@blt blt Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I buy the motivation but what this suggests to me is that the socket for this generator and others should be default bound to localhost but configurable otherwise. I can put up a PR for that.

Copy link
Collaborator

@blt blt Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Said PR: #1725

match conn {
Ok(sock) => {
debug!("UDP port bound");
Expand Down