Example optimization hunt#1762
Closed
preinlein wants to merge 1 commit intopaul.reinlein/selective-benchmarks-in-optimization-loopfrom
Closed
Example optimization hunt#1762preinlein wants to merge 1 commit intopaul.reinlein/selective-benchmarks-in-optimization-loopfrom
preinlein wants to merge 1 commit intopaul.reinlein/selective-benchmarks-in-optimization-loopfrom
Conversation
This was referenced Feb 11, 2026
Merged
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Author
|
Closing this as I don't want to merge these optimizations/optimization hunt results in yet (I've got more changes coming afterwards to make the reports consistent). |
Contributor
Author
|
In case this gets missed in the PR description, the full claude run can be seen here: https://drive.google.com/file/d/1mbgFAFuC5s2HwM3IhoNCgqZcmt7Ho7a2/view?usp=sharing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do?
Implements a zero-copy optimization for
Cache::read_atin the block cache that significantly improves performance for reads that fit within a single block. When a read is contained within one block, the function now returns a slice of the existingBytesinstead of allocating a new buffer and copying data.Motivation
This optimization dramatically improves performance for common read patterns in the logrotate_fs file generator:
Related issues
N/A
Additional Notes
The PR also documents two optimization attempts in the optimization database:
Cache::read_attrace_agent::v04::V04::to_bytesthat reduced memory allocation by 65.6% but showed no timing improvement because serialization cost dominatesThe zero-copy approach works well because:
Bytes(reference-counted)The full Claude run can be found here: https://drive.google.com/file/d/1mbgFAFuC5s2HwM3IhoNCgqZcmt7Ho7a2/view?usp=sharing