Draft
Conversation
Adds win32-x64 to the action-prebuildify "only" filter on both build
and release workflows.
Two supporting fixes for the Windows artifact pipeline:
- scripts/copy-artifacts.js now preserves the .exe extension on
Windows when copying Rust [[bin]] outputs (e.g. crashtracker-receiver),
so the file remains executable after CreateProcess.
- load.js's binary-finder appends .exe on Windows when looking up
binaries (both in build/Release and in prebuilds/win32-x64), so
callers like libdatadog.find('crashtracker-receiver', true) resolve
to the right file.
Upstream libdd-crashtracker (libdatadog v29) already supports Windows
via its collector_windows feature; the receiver binary is a no-op stub
on non-unix targets but still needs to be a real .exe for the in-process
collector path to accept the receiver path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
win32-x64to theaction-prebuildifyonly:filter on bothbuild.ymlandrelease.yml, plus the two supporting fixes needed for the Windows artifact pipeline:scripts/copy-artifacts.jspreserves.exeon Windows when copying Rust[[bin]]outputs (e.g.crashtracker-receiver). Without this, the file gets copied without extension and can't beCreateProcess'd.load.jsappends.exeon Windows when looking up binaries (both inbuild/Releaseand inprebuilds/win32-x64), solibdatadog.find('crashtracker-receiver', true)resolves to the right file.Why
dd-trace-js's crashtracker is currently a silent no-op on Windows because
@datadog/libdatadogships no Windows prebuild, solibdatadog.load('crashtracker')throws and the wrapper falls back to the noop crashtracker. As a result, repeated Windows-onlySTATUS_STACK_BUFFER_OVERRUN(0xC0000409) crashes in the dd-trace-js profiler tests produce no crash reports — see PROF-14469.Upstream
libdd-crashtracker(libdatadog v29) already supports Windows: itsCargo.tomlhas a[target.'cfg(windows)'.dependencies] windows = "0.59.0"block and the default features includecollector_windows(in-process collector). Ourcrates/crashtracker/src/bin/receiver.rsalready has a#[cfg(not(unix))] fn main(){}stub.Test plan
This PR exists primarily to see whether the Windows runner build succeeds. Most likely point of failure is
aws-lc-sys(pulled in byrustlswith theaws-lc-rsprovider). If that breaks on Windows, simplest follow-up is switching the Windows build to theringprovider, or makingaws-lc-rsUnix-only.Related