Skip to content

feat(profiling)!: add OffCpuTime and OffCpuSamples sample types #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vlad-scherbich wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −0
Draft

feat(profiling)!: add OffCpuTime and OffCpuSamples sample types #2135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions libdd-profiling/src/api/sample_type.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ pub enum SampleType {
/// Legacy: Use `WallTime` instead for consistency with naming scheme
WallLegacy,

OffCpuSamples,
OffCpuTime,

// Experimental sample types for testing and development.
ExperimentalCount,
ExperimentalNanoseconds,
Expand Down Expand Up @@ -160,6 +163,8 @@ impl From<SampleType> for ValueType<'static> {
SampleType::WallSamples => ValueType::new("wall-samples", "count"),
SampleType::WallTime => ValueType::new("wall-time", "nanoseconds"),
SampleType::WallLegacy => ValueType::new("wall", "nanoseconds"),
SampleType::OffCpuSamples => ValueType::new("off-cpu-samples", "count"),
SampleType::OffCpuTime => ValueType::new("off-cpu-time", "nanoseconds"),
SampleType::ExperimentalCount => ValueType::new("experimental-count", "count"),
SampleType::ExperimentalNanoseconds => {
ValueType::new("experimental-nanoseconds", "nanoseconds")
Expand Down Expand Up @@ -226,6 +231,8 @@ impl<'a> TryFrom<ValueType<'a>> for SampleType {
("wall-samples", "count") => SampleType::WallSamples,
("wall-time", "nanoseconds") => SampleType::WallTime,
("wall", "nanoseconds") => SampleType::WallLegacy,
("off-cpu-samples", "count") => SampleType::OffCpuSamples,
("off-cpu-time", "nanoseconds") => SampleType::OffCpuTime,
("experimental-count", "count") => SampleType::ExperimentalCount,
("experimental-nanoseconds", "nanoseconds") => SampleType::ExperimentalNanoseconds,
("experimental-bytes", "bytes") => SampleType::ExperimentalBytes,
Expand Down
4 changes: 4 additions & 0 deletions libdd-profiling/src/cxx.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@ pub mod ffi {
WallSamples,
WallTime,
WallLegacy, // LEGACY: Use WallTime instead
OffCpuSamples,
OffCpuTime,
ExperimentalCount,
ExperimentalNanoseconds,
ExperimentalBytes,
Expand Down Expand Up @@ -391,6 +393,8 @@ impl TryFrom<ffi::SampleType> for api::SampleType {
ffi::SampleType::WallSamples => api::SampleType::WallSamples,
ffi::SampleType::WallTime => api::SampleType::WallTime,
ffi::SampleType::WallLegacy => api::SampleType::WallLegacy,
ffi::SampleType::OffCpuSamples => api::SampleType::OffCpuSamples,
ffi::SampleType::OffCpuTime => api::SampleType::OffCpuTime,
ffi::SampleType::ExperimentalCount => api::SampleType::ExperimentalCount,
ffi::SampleType::ExperimentalNanoseconds => api::SampleType::ExperimentalNanoseconds,
ffi::SampleType::ExperimentalBytes => api::SampleType::ExperimentalBytes,
Expand Down
Loading