Add Datadog code coverage upload#339
Merged
xlamorlette-datadog merged 4 commits intomasterfrom Mar 27, 2026
Merged
Conversation
- Adds datadog-ci coverage upload to Makefile coverage target (via apk+npx, required for Alpine/musl-based CI image) - Fetches DD_API_KEY from Vault in GitLab CI coverage job Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #339 +/- ##
=======================================
Coverage 68.85% 68.85%
=======================================
Files 56 56
Lines 7471 7471
Branches 1058 1058
=======================================
Hits 5144 5144
Misses 1820 1820
Partials 507 507 🚀 New features to boost your workflow:
|
Per review feedback: install nodejs/npm in the nginx_musl_toolchain image instead of at runtime in CI. Simplifies the Makefile coverage target. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 1d97316 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
xlamorlette-datadog
approved these changes
Mar 27, 2026
xlamorlette-datadog
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We're migrating Datadog repos from Codecov to Datadog Code Coverage for tracking test coverage. This PR adds a Datadog coverage upload alongside the existing Codecov upload so we can run both systems in parallel and verify parity before switching over.
Changes
Makefile: Addeddatadog-ci coverage uploadafter the existing Codecov upload in thecoveragetarget. Usesapk add nodejs npm && npx @datadog/datadog-cisince the CI image is Alpine/musl-based (no glibc binary available)..gitlab/build-and-test-fast.yml: FetchesDD_API_KEYfrom Vault (kv/k8s/gitlab-runner/nginx-datadog/datadoghq-api-key) and passes it tomake coverage.Why are we doing this?
As part of a company-wide effort, we're consolidating code coverage reporting into Datadog's own Code Coverage product. This gives us:
Notes
|| trueso it cannot fail the buildkv/k8s/gitlab-runner/nginx-datadog/datadoghq-api-keyin Vault (Paweł is adding this)No action needed from reviewers beyond normal review
This is a low-risk, additive change.