Open
Conversation
github-actions
bot
added
the
conventional-commit/chore
Member
|
@darccio you might want your recent fix in this branch |
…ntext.Context` (#798) Go's type checker assigns each loaded package a unique object. If the same package is loaded twice through different means, you get two distinct objects for what is logically the same type. `types.Implements` uses pointer equality to compare types across method signatures, so it sees them as different and returns `false`. `ResolveInterfaceTypeByName` loads context.Context one way; the instrumented code is type-checked another way. The two `context` packages end up as different objects, `types.Implements` fails, and `ArgumentThatImplements` never matches. Fix by falling back to comparing method names and package paths instead of relying on pointer equality.
Member
This comment has been minimized.
This comment has been minimized.
RomainMuller
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corresponding release for dd-trace-go v2.7.1
Includes upgrade to Go 1.25