-
Notifications
You must be signed in to change notification settings - Fork 10
enhancement(api): add dynamic API router based on runtime state #1179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: tobz/runtime-system-state-mgmt-primitives
Are you sure you want to change the base?
Changes from all commits
c15f498
df7d3ca
2205dbb
3522083
b47a600
970d602
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -12,11 +12,14 @@ workspace = true | |||||
| tls-fips = ["saluki-tls/fips"] | ||||||
|
|
||||||
| [dependencies] | ||||||
| arc-swap = { workspace = true } | ||||||
| async-trait = { workspace = true } | ||||||
| axum = { workspace = true } | ||||||
| bytesize = { workspace = true } | ||||||
| chrono = { workspace = true } | ||||||
| chrono-tz = { workspace = true } | ||||||
| http = { workspace = true } | ||||||
| hyper = { workspace = true } | ||||||
|
||||||
| hyper = { workspace = true } |
Copilot
AI
Feb 20, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hyper dependency appears to be unnecessary. The new code in dynamic_api.rs only uses types from the http crate (http::Request, http::Response) and utilities from saluki_io which already depends on hyper. There are no direct imports or usages of hyper types in the added code. Consider removing this dependency unless it's needed for other reasons not visible in this diff.
| hyper = { workspace = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
saluki-apiusestonic::service::Routesandinto_axum_router()insrc/lib.rs, which requires Tonic'srouterfeature (already enabled insaluki-app). As written,tonic = { workspace = true }may fail to compile when buildingsaluki-apiby itself. Enable therouterfeature for thetonicdependency here (or gate the gRPC-related API behind a crate feature).