Skip to content

[WIP] feat(saluki-components): add tag_filterlist transform #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
olivielpeau wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[WIP] feat(saluki-components): add tag_filterlist transform #1247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
53c887b
feat(saluki-components): add tag_filterlist transform with benchmarks
olivielpeau Mar 13, 2026
2a1b918
feat(saluki-components): filter origin_tags in tag_filterlist transform
olivielpeau Mar 13, 2026
1b71247
perf(tag_filterlist): reduce allocations and use foldhash in hot paths
olivielpeau Mar 13, 2026
1aa35a1
bench(tag_filterlist): exclude metric construction from measured iter…
olivielpeau Mar 17, 2026
1883d0b
Make the tags used in micro-benchmark similar to the ones use in core…
olivielpeau Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions bin/agent-data-plane/src/cli/run.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ use saluki_components::{
transforms::{
AggregateConfiguration, ApmStatsTransformConfiguration, ChainedConfiguration, DogstatsDMapperConfiguration,
DogstatsDPrefixFilterConfiguration, HostEnrichmentConfiguration, HostTagsConfiguration,
TraceObfuscationConfiguration, TraceSamplerConfiguration,
TagFilterlistConfiguration, TraceObfuscationConfiguration, TraceSamplerConfiguration,
},
};
use saluki_config::{ConfigurationLoader, GenericConfiguration};
Expand Down Expand Up @@ -414,6 +414,8 @@ async fn add_dsd_pipeline_to_blueprint(
let dsd_mapper_config = DogstatsDMapperConfiguration::from_configuration(config)?;
let dsd_enrich_config =
ChainedConfiguration::default().with_transform_builder("dogstatsd_mapper", dsd_mapper_config);
let dsd_tag_filterlist_config = TagFilterlistConfiguration::from_configuration(config)
.error_context("Failed to configure metric tag filterlist transform.")?;
let dsd_agg_config =
AggregateConfiguration::from_configuration(config).error_context("Failed to configure aggregate transform.")?;
let dd_events_config = DatadogEventsConfiguration::from_configuration(config)
Expand All @@ -428,14 +430,16 @@ async fn add_dsd_pipeline_to_blueprint(
.add_source("dsd_in", dsd_config)?
.add_transform("dsd_prefix_filter", dsd_prefix_filter_configuration)?
.add_transform("dsd_enrich", dsd_enrich_config)?
.add_transform("dsd_tag_filterlist", dsd_tag_filterlist_config)?
.add_transform("dsd_agg", dsd_agg_config)?
.add_encoder("dd_events_encode", dd_events_config)?
.add_encoder("dd_service_checks_encode", dd_service_checks_config)?
.add_destination("dsd_stats_out", dsd_stats_config)?
// Metrics.
.connect_component("dsd_prefix_filter", ["dsd_in.metrics"])?
.connect_component("dsd_enrich", ["dsd_prefix_filter"])?
.connect_component("dsd_agg", ["dsd_enrich"])?
.connect_component("dsd_tag_filterlist", ["dsd_enrich"])?
.connect_component("dsd_agg", ["dsd_tag_filterlist"])?
.connect_component("metrics_enrich", ["dsd_agg"])?
.connect_component("dd_service_checks_encode", ["dsd_in.service_checks"])?
.connect_component("dd_events_encode", ["dsd_in.events"])?
Expand Down
5 changes: 5 additions & 0 deletions lib/saluki-components/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ tracing = { workspace = true }
url = { workspace = true }

[dev-dependencies]
criterion = { workspace = true }
proptest = { workspace = true }
saluki-metrics = { workspace = true, features = ["test"] }
test-strategy = { workspace = true }

[[bench]]
name = "tag_filterlist"
harness = false
Loading
Loading