ci: remove temporary npm auth token configuration step#110
Open
litianningdatadog wants to merge 1 commit intomainfrom
Open
ci: remove temporary npm auth token configuration step#110litianningdatadog wants to merge 1 commit intomainfrom
litianningdatadog wants to merge 1 commit intomainfrom
Conversation
The npm token is now handled via the setup-node action's registry-url, making the explicit `npm config set` step redundant. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes an explicit npm authentication configuration step from the publish workflow, based on the claim that setup-node with registry-url already handles authentication via NODE_AUTH_TOKEN.
Changes:
- Removes the manual
npm config setstep that was explicitly configuring the npm authentication token for publishing
Comments suppressed due to low confidence (1)
.github/workflows/publish.yml:132
- The removed npm authentication configuration step was setting the authentication token for npm publish. While
setup-nodewithregistry-urldoes create an.npmrcfile, it still requires theNODE_AUTH_TOKENenvironment variable to be set for authentication to work. After this change, there is no mechanism to provide the authentication token to npm, which will cause the publish step to fail with authentication errors. The removed lines should either be replaced with anenvsection in the publish job that setsNODE_AUTH_TOKEN: ${{ secrets.NPM_PUBLISH_TOKEN }}, or the explicit token configuration should be restored.
- uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
with:
node-version: "22.x"
registry-url: 'https://registry.npmjs.org'
- name: Publish npm packages
run: |
npm publish ./npm/datadog-serverless-compat-linux-x64 --provenance --access public
npm publish ./npm/datadog-serverless-compat-linux-arm64 --provenance --access public
npm publish ./npm/datadog-serverless-compat-win32-x64 --provenance --access public
npm publish ./npm/datadog-serverless-compat-win32-ia32 --provenance --access public
npm publish ./npm/datadog-serverless-compat-darwin-arm64 --provenance --access public
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code