Skip to content

[ruby] Re-enable telemetry tests#6539

Open
vpellan wants to merge 3 commits intomainfrom
vpellan/ruby-reenable-telemetry-tests
Open

[ruby] Re-enable telemetry tests#6539
vpellan wants to merge 3 commits intomainfrom
vpellan/ruby-reenable-telemetry-tests

Conversation

@vpellan
Copy link
Copy Markdown
Contributor

@vpellan vpellan commented Mar 19, 2026

Motivation

We changed the telemetry keys to env vars in ruby, and we first had to disable the tests to not make the CI red

Changes

Re-enable telemetry tests for ruby

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

manifests/ruby.yml                                                      @DataDog/ruby-guild @DataDog/asm-ruby

Base automatically changed from vpellan/ruby-change-telemetry-keys-to-env-var to main March 19, 2026 16:58
@vpellan vpellan marked this pull request as ready for review March 30, 2026 09:56
@vpellan vpellan requested review from a team as code owners March 30, 2026 09:56
@vpellan vpellan requested review from mhlidd and removed request for a team March 30, 2026 09:56
@vpellan vpellan changed the title [ruby] (do-not-merge) Re-enable telemetry tests [ruby] Re-enable telemetry tests Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants