Skip to content

[FFL-1972] fix(ffe): enable No_Config_Loaded test for Go [golang@sameerank/FFL-1972/fix-flag-evaluation-metrics-consistency-issues]#6577

Closed
sameerank wants to merge 2 commits intosameerank/FFL-1942/add-flag-eval-metricsfrom
sameerank/FFL-1972/fix-flag-evaluation-metrics-consistency-issues-in-go
Closed

[FFL-1972] fix(ffe): enable No_Config_Loaded test for Go [golang@sameerank/FFL-1972/fix-flag-evaluation-metrics-consistency-issues]#6577
sameerank wants to merge 2 commits intosameerank/FFL-1942/add-flag-eval-metricsfrom
sameerank/FFL-1972/fix-flag-evaluation-metrics-consistency-issues-in-go

Conversation

@sameerank
Copy link
Copy Markdown

Motivation

FFL-1972 - Enable the Test_FFE_Eval_No_Config_Loaded test for Go now that dd-trace-go returns provider_not_ready correctly.

Depends on:

Changes

  • Remove @irrelevant decorator for Go from Test_FFE_Eval_No_Config_Loaded
  • Update docstring to remove outdated note about Go returning GENERAL

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?
    • Get a review from R&P team

@github-actions
Copy link
Copy Markdown
Contributor

CODEOWNERS have been resolved as:

tests/ffe/test_flag_eval_metrics.py                                     @DataDog/feature-flagging-and-experimentation-sdk @DataDog/system-tests-core

@datadog-datadog-prod-us1-2
Copy link
Copy Markdown

datadog-datadog-prod-us1-2 bot commented Mar 24, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 204 Tests failed

tests.ffe.test_flag_eval_metrics.Test_FFE_Eval_Config_Exists_Flag_Missing.test_ffe_eval_config_exists_flag_missing[chi] from system_tests_suite   View in Datadog   (Fix with Cursor)
AssertionError: Expected metric for non-existent flag 'non-existent-eval-metric-flag', found none. All: []
assert 0 > 0
 +  where 0 = len([])

self = <tests.ffe.test_flag_eval_metrics.Test_FFE_Eval_Config_Exists_Flag_Missing object at 0x7fbbe80d2600>

    def test_ffe_eval_config_exists_flag_missing(self):
        """Test that missing flag (with config loaded) produces error.type=flag_not_found."""
        assert self.r.status_code == 200, f"Flag evaluation request failed: {self.r.text}"
    
...
tests.ffe.test_flag_eval_metrics.Test_FFE_Eval_Config_Exists_Flag_Missing.test_ffe_eval_config_exists_flag_missing[django-poc] from system_tests_suite   View in Datadog   (Fix with Cursor)
AssertionError: Expected metric for non-existent flag 'non-existent-eval-metric-flag', found none. All: []
assert 0 > 0
 +  where 0 = len([])

self = <tests.ffe.test_flag_eval_metrics.Test_FFE_Eval_Config_Exists_Flag_Missing object at 0x7f31f01b9a00>

    def test_ffe_eval_config_exists_flag_missing(self):
        """Test that missing flag (with config loaded) produces error.type=flag_not_found."""
        assert self.r.status_code == 200, f"Flag evaluation request failed: {self.r.text}"
    
...
tests.ffe.test_flag_eval_metrics.Test_FFE_Eval_Config_Exists_Flag_Missing.test_ffe_eval_config_exists_flag_missing[django-py3.13] from system_tests_suite   View in Datadog   (Fix with Cursor)
AssertionError: Expected metric for non-existent flag 'non-existent-eval-metric-flag', found none. All: []
assert 0 > 0
 +  where 0 = len([])

self = <tests.ffe.test_flag_eval_metrics.Test_FFE_Eval_Config_Exists_Flag_Missing object at 0x7fe2a85815e0>

    def test_ffe_eval_config_exists_flag_missing(self):
        """Test that missing flag (with config loaded) produces error.type=flag_not_found."""
        assert self.r.status_code == 200, f"Flag evaluation request failed: {self.r.text}"
    
...
View all

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 31a3a77 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@sameerank sameerank changed the title [golang] fix(ffe): enable No_Config_Loaded test for Go [93e777213bffebb0bb61d828b77380852956e5e9] [FFL-1972] fix(ffe): enable No_Config_Loaded test for Go [golang@sameerank/FFL-1972/fix-flag-evaluation-metrics-consistency-issues] Mar 24, 2026
@sameerank
Copy link
Copy Markdown
Author

Closing in favor of consolidating into PR #6545 with multiple language tags.

@sameerank sameerank closed this Mar 24, 2026
@cbeauchesne cbeauchesne deleted the sameerank/FFL-1972/fix-flag-evaluation-metrics-consistency-issues-in-go branch March 26, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant