[ruby] Add support for enhanced config reporting in ruby#6643
Conversation
|
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ac93d5952e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| Datadog.configure do |c| | ||
| c.diagnostics.debug = true | ||
| c.tracing.log_injection = true if ENV['CONFIG_CHAINING_TEST'] == 'true' |
There was a problem hiding this comment.
Guard
c.tracing access behind capability check
CONFIG_CHAINING_TEST now triggers c.tracing.log_injection = true unconditionally, but this initializer still explicitly supports legacy tracer config objects right below via c.respond_to?(:tracing). For tracer versions that do not expose c.tracing, enabling this scenario env var causes a boot-time exception before the fallback path can run, so the Ruby weblog fails to start. Please guard this new assignment with the same capability check (and apply the same fix to the other Ruby weblog initializers changed in this commit).
Useful? React with 👍 / 👎.
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: ac93d59 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
Motivation
Wrapping up config viz for 26Q1
Changes
Programmatically activate logs injection if CONFIG_CHAINING_TEST env var is detected on Ruby weblogs. Add ruby in EXPECTED_CONFIGS. Disable easy-wins that are now failing (they were not supposed to pass anyway). They will be reenabled once DataDog/dd-trace-rb#5483 is merged
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present