test(otel): exercise http/protobuf in APM_TRACING_OTLP scenario#7131
Draft
bm1549 wants to merge 1 commit into
Draft
test(otel): exercise http/protobuf in APM_TRACING_OTLP scenario#7131bm1549 wants to merge 1 commit into
bm1549 wants to merge 1 commit into
Conversation
Sets OTEL_EXPORTER_OTLP_TRACES_PROTOCOL=http/protobuf on the APM_TRACING_OTLP scenario so Test_Otel_Tracing_OTLP covers the OTLP HTTP/protobuf export path. The test already handles both JSON and protobuf content-types. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
APM_TRACING_OTLPexercises the OTLP trace-export path but does not pin a protocol, so the newhttp/protobufOTLP encoding in dd-trace-py is not covered. This adds protobuf coverage toTest_Otel_Tracing_OTLP.Changes
Sets
OTEL_EXPORTER_OTLP_TRACES_PROTOCOL=http/protobufon theAPM_TRACING_OTLPscenario weblog env.Test_Otel_Tracing_OTLPalready normalizes both JSON and protobuf payloads (theis_jsoncontent-type branch + the_trace_id_to_hexhelper), so no test-logic change is needed.Depends on the dd-trace-py OTLP http/protobuf feature (DataDog/dd-trace-py#18609) being present in the tested tracer build.
Workflow
Reviewer checklist
tests/ormanifests/is modified ? Yes —utils/_context/_scenarios/__init__.py(scenario env). Will get R&P approval before marking ready.