dev_kas #8
Open
dev_kas #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 24, 2025 10:58
# Conflicts: # geodjango/samplelocations/migrations/0002_datastream_observation_location_sample_sensor_thing_and_more.py
geodjango/samplelocations/models.py
Outdated
| # Define class-based choices for the 'thing_type' field. | ||
| # This allows for a more structured way to define and use choices in Django models. | ||
| # The format is CHOICE = " database value", "human-readable or display name" | ||
| class ThingType(models.TextChoices): |
Contributor
There was a problem hiding this comment.
Can this be defined outside of the Thing class? I think that will make it easier to understand and follow
geodjango/samplelocations/models.py
Outdated
|
|
||
| #Fields specific to a SPRING | ||
| spring_type = models.CharField(max_length=255, blank=True, null=True) # e.g. "artesian", "subartesian", "thermal", etc. | ||
| description_spring = models.CharField(max_length=255, blank=True, null=True) |
Contributor
There was a problem hiding this comment.
instead of restricting description to a particular thing type, how about just having a general description field for all things?
Author
There was a problem hiding this comment.
Yeah, I was trying to think of another spring-specific field, but description does seem applicable to a general Thing.
added 6 commits
July 30, 2025 09:45
jacob-a-brown
approved these changes
Jul 30, 2025
Contributor
jacob-a-brown
left a comment
jacob-a-brown
left a comment
There was a problem hiding this comment.
this looks good to me
chasetmartin
approved these changes
Jul 31, 2025
Contributor
chasetmartin
left a comment
chasetmartin
left a comment
There was a problem hiding this comment.
This looks good to me too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: