feat: refactor transfer_all function and add transferable_wells utility#455
Merged
feat: refactor transfer_all function and add transferable_wells utility#455
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the transfer_all function to simplify its interface and moves configuration management inside the function. It also introduces a new utility script for identifying transferable wells.
Changes:
- Simplified
transfer_allfunction signature by removing parameters and managing configuration internally via environment variables - Removed unused
profile_waterlevelsparameter from_run_continuous_water_level_transfers - Added
transferable_wells.pyutility script to extract and export transferable wells data
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| transfers/transferable_wells.py | New utility script that reads well data, filters transferable wells, and exports to CSV |
| transfers/transfer.py | Refactored transfer_all to simplify interface and manage configuration internally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
How
Implementation summary - the following was changed / added / removed:
Notes
Any special considerations, workarounds, or follow-up work to note?