feat: add new thing types and transfer functions for rock samples, surface water diversions, lakes, soil gas samples, and outfalls #462
Conversation
…rface water diversions, lakes, soil gas samples, and outfalls
There was a problem hiding this comment.
Pull request overview
This PR adds support for transferring six new location/thing types (rock samples, surface water diversions, lakes, soil gas samples, other site types, and outfalls) to the data transfer system. The implementation refactors the existing transfer logic to use a dynamic approach for processing these types.
Changes:
- Added six new transfer functions and corresponding transfer options for new thing types
- Refactored the transfer loop to dynamically discover and call transfer functions using globals()
- Added lexicon definitions for the new thing types
- Extracted duplicate release status logic into a helper function
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| transfers/transfer.py | Added new transfer options and refactored non-well task loop to use dynamic function lookup |
| transfers/thing_transfer.py | Added transfer functions for six new thing types and extracted _release_status helper |
| core/lexicon.json | Added lexicon entries for the six new thing types |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d6bf42cd20
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… in chemistry_sampleinfo
| from starlette.requests import Request | ||
| from starlette_admin import HasOne |
There was a problem hiding this comment.
These imports appear to be unused in the visible diff. If they are not used elsewhere in the file, they should be removed to avoid clutter.
1 participant
Why
This PR addresses the following problem / context:
How
Implementation summary - the following was changed / added / removed:
Notes
Any special considerations, workarounds, or follow-up work to note?