BDMS-540: Link NMA_WeatherPhotos to NMA_WeatherData#470
Open
ksmuczynski wants to merge 2 commits intokas-bdms-540-NMA_SurfaceWaterPhotos-FK-relationshipfrom
Open
Conversation
…NMA_WeatherPhotos via WeatherID - move weather_id under FK section and enforce NOT NULL - add FK + relationship + validator on NMA_WeatherPhotos - mark NMA_WeatherData.weather_id unique for FK target - run WeatherPhotos transfer after WeatherData and skip orphan photos - add migration to backfill/cleanup and enforce FK/NOT NULL - update legacy tests to create WeatherPhotos with a real parent WeatherData
ksmuczynski
requested review from
TylerAdamMartinez,
jacob-a-brown,
jirhiker and
kbighorse
Member
|
My hope was that these types of changes would be taken care of in the db refactor and data transformation step that is to follow the 1:1 migration. Given we are so close to having migrated all the data I'd like to limit the modifications to the transfer script |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
NMA_WeatherPhotoslacked a direct FK relationship toWeatherData, making joins and integrity checks harder.How
Implementation summary - the following was changed / added / removed:
WeatherIDFK relationship betweenNMA_WeatherPhotosandNMA_WeatherData.WeatherPhototransfer to use the new relationship and aligns transfer helpers.WeatherPhototests to cover theWeatherIDrelationship.Notes
Any special considerations, workarounds, or follow-up work to note?
- !! This is the last PR in the chain of "BDMS-540:..." PRs (467-469).