Conversation
|
lgtm |
…os and validation
|
@chasetmartin sorry i meant to open a pull request but I push directly to your branch. These edits are a combination of first running the spec through the Feature File GPT and second, making manual updates to clean up. |
|
@jirhiker No worries thanks for the improvements, I'll check them out more Monday morning. |
jacob-a-brown
left a comment
There was a problem hiding this comment.
Are 422 status code responses supposed to in the Pydantic style?
| | contact_name | | ||
| | contact_organization | | ||
| | contact_role | | ||
| | contact_type | |
There was a problem hiding this comment.
the user can submit 2 contacts. should this be changed to ..._1 and then replicated for the second contact?
There was a problem hiding this comment.
I intentionally kept this feature to a single contact to start for simplicity. However, a user Slacked me that "a few" backlogged wells have 2 contacts. So @jirhiker do you think we should add replica fields for a 2nd contact via csv? It will make the csv very wide, but it will also reduce the need for a user to keep track of situations where they have to go back and add a contact after import.
|
@jirhiker Let me know if the changes I just made make sense. I added the communication preference and notes fields Sianin requested and duplicated the contact fields so there is a contact_1 and a contact_2. |
|
Added one additional field, sample_possible to record whether it's possible to sample the well. This question is hidden on the 2nd page of the inventory form. |
@jacob-a-brown Sorry just saw this. I think that makes sense for consistency throughout the app. @jirhiker Let me know if you think the feature file should be updated to be specific about this, or if that's just an implementation detail for these 422 responses? |
|
|
|
@chasetmartin There are more @Negative scenarios to define. e.g. invalid state. |
|
@jirhiker I added more negative scenarios, let me know of others you encounter as you work. Do you think we should have a negative validation scenario for the binary true/false fields? Also so this is linked to this feature, here is the Google Sheet template for the csv creation: |
…ing and additional negative validation cases
…icon and field requirements
…tive and negative validation cases
…red fields and improved negative validation cases
…nd improve clarity
…e_point_id using "XY-" prefix
Why
This PR addresses the following problem / context:
I want to upload a CSV file containing well inventory data for multiple wells
So that many wells can be imported quickly and accurately into the system
How
Implementation summary - the following was changed / added / removed:
Notes
Any special considerations, workarounds, or follow-up work to note?