Skip to content

feat(panel-switcher): add panel switcher plugin#20

Merged
SlimDeluxe merged 1 commit intoDataLinx:mainfrom
KilianTrunk:feat/panel-switcher
Aug 13, 2025
Merged

feat(panel-switcher): add panel switcher plugin#20
SlimDeluxe merged 1 commit intoDataLinx:mainfrom
KilianTrunk:feat/panel-switcher

Conversation

@KilianTrunk
Copy link
Contributor

No description provided.

@KilianTrunk
Copy link
Contributor Author

here is the preview :

Screen.Recording.2025-07-31.at.11.25.06.mov

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.29%. Comparing base (bc76271) to head (4dc1153).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #20      +/-   ##
============================================
+ Coverage     73.10%   73.29%   +0.18%     
  Complexity      289      289              
============================================
  Files            54       54              
  Lines          1848     1861      +13     
============================================
+ Hits           1351     1364      +13     
  Misses          497      497              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KilianTrunk KilianTrunk marked this pull request as draft July 31, 2025 10:19
@KilianTrunk
Copy link
Contributor Author

based on the plugin's source code, it already hides itself when there are fewer than 2 panels available :

if (count($static->getPanels()) < 2) {
    $static->visible(false);
}

source : vendor/bezhansalleh/filament-panel-switch/src/PanelSwitch.php

@SlimDeluxe
Copy link
Member

Looks functional, but it's getting too crowded with all the switchers/dropdowns.
However, let's merge this and improve it later.

@SlimDeluxe
Copy link
Member

Is there anything more you wanted to do here? If not, set it as "ready for review" so I can merge.
Don't worry about the translations, that's one of the last things to do, since this stuff could still change or even be removed.

@KilianTrunk KilianTrunk marked this pull request as ready for review August 4, 2025 09:28
@SlimDeluxe SlimDeluxe merged commit 8fcff7e into DataLinx:main Aug 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants