feat: added login tracking and login count features to User model#3
feat: added login tracking and login count features to User model#3SlimDeluxe merged 5 commits intoDataLinx:mainfrom
Conversation
SlimDeluxe
left a comment
There was a problem hiding this comment.
Seems ok, but the updateLoginTracking should be automatically called when a user logs in. I guess this needs to be done with an event&listener, but I don't see this in the provided code.
|
Hello @SlimDeluxe, I have made all the changes you highlighted and done some refactoring. |
|
The corrections you made are great. I've tested it locally and it seems OK. |
Oh, I made the changes for this in the user-trash-restore branch. So, I had to commit my changes on that branch and pull into this branch. |
|
Hello @SlimDeluxe , I have removed the trash restore feature commit from this branch now. |
SlimDeluxe
left a comment
There was a problem hiding this comment.
Hi, I've requested further fixes, please update the PR
database/migrations/2025_03_15_000001_add_soft_deletes_to_users.php
Outdated
Show resolved
Hide resolved
c259bcc to
1f4e6ec
Compare
|
Hello @SlimDeluxe , I have made the further fixes you pointed out. |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Added login tracking feature to the User model.
last_login_atandlogin_count/claim #2