Skip to content

feat: added login tracking and login count features to User model#3

Merged
SlimDeluxe merged 5 commits intoDataLinx:mainfrom
sparkybug:add-login-tracking
Mar 17, 2025
Merged

feat: added login tracking and login count features to User model#3
SlimDeluxe merged 5 commits intoDataLinx:mainfrom
sparkybug:add-login-tracking

Conversation

@sparkybug
Copy link
Contributor

Added login tracking feature to the User model.

  • Tracks last_login_at and login_count
  • Updates these fields on user login
  • Displays them in Filament with filtering and sorting
  • Adds feature tests to validate functionality

/claim #2

@algora-pbc algora-pbc bot mentioned this pull request Mar 15, 2025
3 tasks
Copy link
Member

@SlimDeluxe SlimDeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok, but the updateLoginTracking should be automatically called when a user logs in. I guess this needs to be done with an event&listener, but I don't see this in the provided code.

@sparkybug
Copy link
Contributor Author

Hello @SlimDeluxe, I have made all the changes you highlighted and done some refactoring.
Kindly review.
Thanks.

@SlimDeluxe
Copy link
Member

The corrections you made are great. I've tested it locally and it seems OK.
However this PR now includes the trashed feature commit for some reason. I am not sure how it happened, but can you remove the unrelated commit from this PR?
I would merge both but the trashed one is still not complete.

@sparkybug
Copy link
Contributor Author

The corrections you made are great. I've tested it locally and it seems OK. However this PR now includes the trashed feature commit for some reason. I am not sure how it happened, but can you remove the unrelated commit from this PR? I would merge both but the trashed one is still not complete.

Oh, I made the changes for this in the user-trash-restore branch. So, I had to commit my changes on that branch and pull into this branch.
I have fixed the issues you highlighted in that branch now though. Kindly review.

@sparkybug
Copy link
Contributor Author

Hello @SlimDeluxe , I have removed the trash restore feature commit from this branch now.

Copy link
Member

@SlimDeluxe SlimDeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I've requested further fixes, please update the PR

@sparkybug sparkybug force-pushed the add-login-tracking branch from c259bcc to 1f4e6ec Compare March 17, 2025 08:22
@sparkybug
Copy link
Contributor Author

Hello @SlimDeluxe , I have made the further fixes you pointed out.
kindly review, thanks.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@SlimDeluxe SlimDeluxe merged commit e4afe56 into DataLinx:main Mar 17, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants