Conversation
SlimDeluxe
left a comment
There was a problem hiding this comment.
I see you are not checking permissions, but only the logged in state.
Please see here how to update permissions.
Also note that you can set up a super admin by calling this method in your test:
$this->set_up_super_admin_and_tenant();
This "logs in" a super admin with all permissions.
|
@sparkybug , I see you added permissions checks, but they are custom and not using Filament Shield. As I've mentioned before, you need to follow this procedure to create new permissions and update the policy.
|
Hello @SlimDeluxe , I have done as requested. Sorry I was misunderstanding you all these while. |
|
Thank you, I've taken a quick look and unfortunately it appears it's not quite ready. I'll do the review tomorrow. |
SlimDeluxe
left a comment
There was a problem hiding this comment.
Sorry, some more fixes are required.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
=========================================
Coverage 59.26% 59.26%
Complexity 111 111
=========================================
Files 28 28
Lines 734 734
=========================================
Hits 435 435
Misses 299 299 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hello @SlimDeluxe , I have made all fixes as you pointed out. |
|
Hi @sparkybug, thank you, this is now merged :) |
/claim #1