Skip to content

feat(workbench): make plugin development self-contained#12

Closed
KilianTrunk wants to merge 25 commits intoDataLinx:mainfrom
KilianTrunk:feat/workbench
Closed

feat(workbench): make plugin development self-contained#12
KilianTrunk wants to merge 25 commits intoDataLinx:mainfrom
KilianTrunk:feat/workbench

Conversation

@KilianTrunk
Copy link
Contributor

No description provided.

@KilianTrunk KilianTrunk marked this pull request as draft August 7, 2025 07:24
@KilianTrunk
Copy link
Contributor Author

@SlimDeluxe can you try pulling, running composer install inside workbench, then rebuilding lando in the root? I tried cloning my fork, switched to my feature branch, ran composer install inside workbench, went to root (eclipsephp-world-plugin), and ran lando rebuild -y, and everything seems to work

@SlimDeluxe
Copy link
Member

Hm, looking at the file changes and there's simply too much stuff. If we can't keep it simple, it's not worth it. Too much duplicated code to maintain.
Need to think about this.

@KilianTrunk
Copy link
Contributor Author

Hm, looking at the file changes and there's simply too much stuff. If we can't keep it simple, it's not worth it. Too much duplicated code to maintain. Need to think about this.

Had the same thought, I wouldn’t put so much time into it.

The only thing we can reduce is the amout of migrations I believe, but this is the minimum for this to work sadly.

What I would do is create a dev script that would clone every repo in the correct folder, run composer installs and what not, and then that would be easier. Or even a package that lets you choose which of the plugins you want to install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants